-
Notifications
You must be signed in to change notification settings - Fork 10
add sqlalchemy backend #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is mostly done. I still have to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the intention to remove .github/workflows/publish.yml
permanently and just deploy manually, or are you planning on replacing that with a different workflow?
Co-authored-by: Jon Duckworth <[email protected]>
Not permanently, I think deploy should be automated but just not sure what the deploy looks like yet. I think we should definitely deploy a docker container, not sure if we should also publish a library. |
…ule name to stac_fastapi
I'd like to get this merged before switching everything over to stac-utils/stac-fastapi#450 |
A Docker container would be great. I think publishing the library would be helpful, too. I've built a couple applications already where I import and inherit from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me @geospatial-jeff, and I was able to run everything based on the instructions in the README.
I had a couple of inline comments, but no big blockers. I also liked your suggestion in stac-utils/stac-fastapi#450(comment) that we consolidate the Docker images into a single Dockerfile. Should we maybe do that here as well?
pip install -e stac_fastapi/sqlalchemy | ||
# or | ||
pip install -e stac_fastapi/pgstac | ||
pip install stac-fastapi.sqlalchey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip install stac-fastapi.sqlalchey | |
pip install stac-fastapi.sqlalchemy |
minor typo
- "python" | ||
- "/app/scripts/ingest_joplin.py" | ||
- "http://app-pgstac:8082" | ||
bash -c "./scripts/wait-for-it.sh stac-fastapi-sqlalchemy:8081 && alembic upgrade head && python /app/scripts/ingest_joplin.py http://stac-fastapi-sqlalchemy:8081" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bash -c "./scripts/wait-for-it.sh stac-fastapi-sqlalchemy:8081 && alembic upgrade head && python /app/scripts/ingest_joplin.py http://stac-fastapi-sqlalchemy:8081" | |
bash -c "./scripts/wait-for-it.sh -t 30 stac-fastapi-sqlalchemy:8081 && alembic upgrade head && python /app/scripts/ingest_joplin.py http://stac-fastapi-sqlalchemy:8081" |
This is not necessarily related to this PR, but this almost always times out for me when starting from a fresh slate. The service seems to become available after about 19 or 20 seconds, so increasing this timeout to 30s should cover us.
Closing as OBE, see stac-utils/stac-fastapi#517 for details. |
No description provided.