Skip to content

Update filter conformance classes #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 31, 2022
Merged

Update filter conformance classes #417

merged 6 commits into from
Jul 31, 2022

Conversation

m-mohr
Copy link
Contributor

@m-mohr m-mohr commented Jun 27, 2022

The filter conformance classes seem to be completely wrong. They don't even match the (wrong) ones in rc.1.

See also radiantearth/stac-api-spec#312

I'm not sure which one of the constants if for ogcapi-features though, so the changes may need to be swapped.

Looking at this, the question also arises why for example https://api.stacspec.org/v1.0.0-rc.1/ogcapi-features#sort is not used anywhere in stac-fastapi?

@m-mohr m-mohr requested a review from philvarner June 27, 2022 23:10
@geospatial-jeff
Copy link
Collaborator

geospatial-jeff commented Jul 28, 2022

Looking at this, the question also arises why for example https://api.stacspec.org/v1.0.0-rc.1/ogcapi-features#sort is not used anywhere in stac-fastapi?

The sort extension currently uses https://api.stacspec.org/v1.0.0-rc.1/item-search#sort (see here), @m-mohr should it use the ogcapi-features href instead?

@m-mohr
Copy link
Contributor Author

m-mohr commented Jul 28, 2022

The sort extension currently uses https://api.stacspec.org/v1.0.0-rc.1/item-search#sort (see here), @m-mohr should it use the ogcapi-features href instead?

Depends on where it is supported, I think.
.../item-search#sort if it is supported for /search
.../ogcapi-features#sort if it is supported for /collections/...

Similarly for all the others... @geospatial-jeff

@philvarner
Copy link
Collaborator

Correct -- except for filter, where we re-use the OGC conformance class binding filter to OAFeat

@m-mohr
Copy link
Contributor Author

m-mohr commented Jul 28, 2022

But there are still separate conformance classes, only that there's no "new" one for STAC, right?

@philvarner
Copy link
Collaborator

But there are still separate conformance classes, only that there's no "new" one for STAC, right?

correct

@geospatial-jeff
Copy link
Collaborator

@philvarner How does it look now? I updated the item search and filter conformance classes, and added the features filter conformance class which was previously missing.

@geospatial-jeff geospatial-jeff self-requested a review July 31, 2022 02:43
@geospatial-jeff geospatial-jeff merged commit 286fd98 into master Jul 31, 2022
@geospatial-jeff geospatial-jeff deleted the m-mohr-patch-1 branch July 31, 2022 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants