Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
WIP PR to allow response models to actually be used to validate outgoing objects. Currently just has a failing test.
We currently wrap every response in a
Response
of some sort:stac-fastapi/stac_fastapi/api/stac_fastapi/api/routes.py
Lines 18 to 25 in fc06ac3
This short-circuits the response model system in FastAPI: https://github.com/tiangolo/fastapi/blob/40df42f5c7d92815ceeb546df60256dacb3eed57/fastapi/routing.py#L241-L244
To fix, we'll need to pass through raw JSON objects as-is if response models are enabled.
PR Checklist:
pre-commit run --all-files
)make test
)make docs
)