Skip to content

Fix for tags for ghcr images in README #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2023
Merged

Fix for tags for ghcr images in README #531

merged 1 commit into from
Feb 27, 2023

Conversation

gadomski
Copy link
Member

Related Issue(s):

Description:

We'll need to change these to tagged versions once a tagged version is released and published to ghcr.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@gadomski
docs, fix: tags for ghcr images
ff21e94 
We'll need to change these to tagged versions once a tagged version is released.
@gadomski gadomski added the documentation Improvements or additions to documentation label Feb 24, 2023
@gadomski gadomski added this to the 2.4.4 milestone Feb 24, 2023
@gadomski gadomski requested a review from pjhartzell February 24, 2023 14:31
@gadomski gadomski self-assigned this Feb 24, 2023
@gadomski gadomski changed the title Fags for ghcr images in README Fix for tags for ghcr images in README Feb 24, 2023
moradology
moradology approved these changes Feb 27, 2023
View reviewed changes
Copy link
Collaborator

@moradology moradology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. docker pull ghcr.io/stac-utils/stac-fastapi:master-pgstac is working as advertised

@gadomski gadomski merged commit 2482467 into master Feb 27, 2023
@gadomski gadomski deleted the fix-ghcr-tags-in-docs branch February 27, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moradology moradology moradology approved these changes

@pjhartzell pjhartzell Awaiting requested review from pjhartzell

Assignees

@gadomski gadomski

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
2.4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@gadomski @moradology