Skip to content

Fix Github Pages deploy #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2023
Merged

Fix Github Pages deploy #571

merged 2 commits into from
May 9, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented May 9, 2023 •
edited
Loading

Description:

Our "publish docs" CI step failed after #555. This fixes that up, hopefully. We can't know until we merge with main, but we add workflow_dispatch so we can trigger this publish step manually after this is merged (e.g. from a second fixup PR). Doesn't need a CHANGELOG entry or documentation.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@gadomski gadomski added the github_actions Pull requests that update GitHub Actions code label May 9, 2023
@gadomski gadomski requested a review from pjhartzell May 9, 2023 18:33
@gadomski gadomski self-assigned this May 9, 2023
pjhartzell
pjhartzell approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@pjhartzell pjhartzell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@gadomski gadomski enabled auto-merge (squash) May 9, 2023 20:10
@gadomski gadomski merged commit feffe2b into main May 9, 2023
@gadomski gadomski deleted the fix-docs-deploy branch May 9, 2023 20:12
@gadomski gadomski added this to the 2.4.6 milestone May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjhartzell pjhartzell pjhartzell approved these changes

Assignees

@gadomski gadomski

Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
2.4.6
Development

Successfully merging this pull request may close these issues.
2 participants
@gadomski @pjhartzell