Skip to content

feat: Airflow 3.0.1 (experimental) #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Jun 3, 2025
Merged

feat: Airflow 3.0.1 (experimental) #630

merged 28 commits into from
Jun 3, 2025

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented May 20, 2025

Description

Related to #618

Most changes in this PR are due to the fact that the API has changed and both old and new versions need to be available for the tests. Code changes can be summarised as:

  • adding a condition for the start commands
  • adding a condition for new env-vars
  • minor change to logging definition

N.B. this PR does not cover updates to OPA-Auth (covered separately).

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the [style guide]
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Roadmap has been updated

@adwk67 adwk67 mentioned this pull request May 15, 2025
6 tasks
@adwk67 adwk67 marked this pull request as ready for review May 27, 2025 11:12
@adwk67 adwk67 moved this to Development: Waiting for Review in Stackable Engineering May 27, 2025
@adwk67 adwk67 self-assigned this May 27, 2025
@maltesander maltesander self-requested a review May 27, 2025 12:39
@maltesander maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 27, 2025
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch, will do some more testing.

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I missed it, but it looks like the supported-version.adoc is missing the 3.0.1 (experimental) addition

@adwk67
Copy link
Member Author

adwk67 commented Jun 2, 2025

Sorry if I missed it, but it looks like the supported-version.adoc is missing the 3.0.1 (experimental) addition

No, you were correct - thanks! 9dfe57e

maltesander
maltesander previously approved these changes Jun 2, 2025
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests (OS) pass :)

@adwk67 adwk67 dismissed NickLarsenNZ’s stale review June 2, 2025 15:43

Changes made as requested.

@adwk67
Copy link
Member Author

adwk67 commented Jun 3, 2025

LGTM if tests (OS) pass :)

--- PASS: kuttl (1305.41s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/oidc_airflow-latest-3.0.1_openshift-true (178.30s)
        --- PASS: kuttl/harness/cluster-operation_airflow-latest-3.0.1_openshift-true (299.92s)
        --- PASS: kuttl/harness/mount-dags-gitsync_airflow-latest-3.0.1_openshift-true_executor-kubernetes (237.70s)
        --- PASS: kuttl/harness/smoke_airflow-3.0.1_openshift-true_executor-kubernetes (222.45s)
        --- PASS: kuttl/harness/opa_airflow-non-experimental-2.10.5_opa-latest-1.4.2_openshift-true (145.10s)
        --- PASS: kuttl/harness/overrides_airflow-latest-3.0.1_openshift-true (177.37s)
        --- PASS: kuttl/harness/external-access_airflow-3.0.1_openshift-true_executor-kubernetes (205.12s)
        --- PASS: kuttl/harness/orphaned-resources_airflow-latest-3.0.1_openshift-true (171.69s)
        --- PASS: kuttl/harness/resources_airflow-latest-3.0.1_openshift-true (157.78s)
        --- PASS: kuttl/harness/mount-dags-configmap_airflow-latest-3.0.1_openshift-true_executor-kubernetes (167.62s)
        --- PASS: kuttl/harness/logging_airflow-3.0.1_openshift-true_executor-kubernetes (362.40s)
        --- PASS: kuttl/harness/ldap_airflow-latest-3.0.1_ldap-authentication-server-verification-tls_openshift-true_executor-kubernetes (204.12s)
PASS

maltesander
maltesander previously approved these changes Jun 3, 2025
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adwk67 adwk67 enabled auto-merge June 3, 2025 15:03
@adwk67 adwk67 added this pull request to the merge queue Jun 3, 2025
Merged via the queue into main with commit 24395c2 Jun 3, 2025
16 of 17 checks passed
@adwk67 adwk67 deleted the feat/airflow-3.0.0 branch June 3, 2025 15:17
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Jun 3, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants