chore: Listener class at webserver role level only #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltesander
requested changes
Jun 20, 2025
| match role { | ||
| AirflowRole::Webserver => Some(rolegroup.object_name()), | ||
| AirflowRole::Webserver => Some(format!( | ||
| "{cluster_name}-{role}", |
There was a problem hiding this comment.
This is somewhat used as well in execution_server_env_vars. Can we make that a method?
| @@ -14,13 +14,15 @@ | |||
| ) | |||
|
|
|||
| parser = argparse.ArgumentParser(description="Health check script") | |||
| parser.add_argument("--role-group", type=str, default="default", help="Role group to check") | |||
| @@ -916,7 +910,7 @@ fn build_server_rolegroup_statefulset( | |||
| // A version value is required, and we do want to use the "recommended" format for the other desired labels | |||
| "none", | |||
| &rolegroup_ref.role, | |||
| &rolegroup_ref.role_group, | |||
| "none", | |||
There was a problem hiding this comment.
Maybe we actually want a method in op-rs without rolegroup, before we hardcode this in every operator?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add a description here. This will become the commit message of the merge request later.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker