-
-
Notifications
You must be signed in to change notification settings - Fork 7
feat(kafka): Build kafka-opa-plugin from source #1177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8a6c4aa
to
cf0ea72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: I merged the main branch which caused some conflicts because of my PR that introduced custom versions for Kafka, I resolved them.
Your PR looks fine, I did some tests and everything seems to work as expected, thanks!
I just think some commented out lines need to be removed (see suggestions), then we can merge it.
clean up Dockerfile Co-authored-by: Lukas Krug <[email protected]>
Description
Build kafka-opa-plugin from source.
Tested the image locally since we don't have an integration test for Kafka with OPA yet.
Definition of Done Checklist
Note
Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.
Please make sure all these things are done and tick the boxes
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
bake
to retrieve the image tag for<image-tagged-with-the-major-version>
.