Skip to content

feat(kafka): Build kafka-opa-plugin from source #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 24, 2025

Conversation

labrenbe
Copy link
Member

@labrenbe labrenbe commented Jun 16, 2025

Description

Build kafka-opa-plugin from source.

Tested the image locally since we don't have an integration test for Kafka with OPA yet.

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Changes are OpenShift compatible
  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
  • All packages should have (if available) signatures/hashes verified
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@labrenbe labrenbe self-assigned this Jun 16, 2025
@labrenbe labrenbe moved this to Development: In Progress in Stackable Engineering Jun 16, 2025
@labrenbe labrenbe moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Jun 20, 2025
@labrenbe labrenbe marked this pull request as ready for review June 20, 2025 14:06
@dervoeti dervoeti self-requested a review June 23, 2025 13:15
@dervoeti dervoeti moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 23, 2025
@dervoeti dervoeti force-pushed the feat/build-kafka-opa-plugin-from-source branch from 8a6c4aa to cf0ea72 Compare June 23, 2025 18:01
Copy link
Member

@dervoeti dervoeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I merged the main branch which caused some conflicts because of my PR that introduced custom versions for Kafka, I resolved them.
Your PR looks fine, I did some tests and everything seems to work as expected, thanks!
I just think some commented out lines need to be removed (see suggestions), then we can merge it.

clean up Dockerfile

Co-authored-by: Lukas Krug <[email protected]>
@labrenbe labrenbe added this pull request to the merge queue Jun 24, 2025
Merged via the queue into main with commit bca4124 Jun 24, 2025
3 checks passed
@labrenbe labrenbe deleted the feat/build-kafka-opa-plugin-from-source branch June 24, 2025 08:26
@labrenbe labrenbe moved this from Development: In Review to Development: Done in Stackable Engineering Jun 24, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants