Skip to content

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Sep 16, 2025

Description

Part of #1233

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Add an entry to the CHANGELOG.md file
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@xeniape xeniape self-assigned this Sep 16, 2025
@xeniape xeniape linked an issue Sep 16, 2025 that may be closed by this pull request
12 tasks
@xeniape xeniape marked this pull request as ready for review September 16, 2025 14:47
@xeniape xeniape moved this to Development: Waiting for Review in Stackable Engineering Sep 16, 2025
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and I assume local image builds succeed?

@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Sep 17, 2025
@xeniape
Copy link
Member Author

xeniape commented Sep 17, 2025

LGTM, and I assume local image builds succeed?

Yep, the acceptance TODOs were in the parent issue

@xeniape xeniape requested a review from Techassi September 17, 2025 09:03
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I would recommend waiting to merge this at CoB today.

@xeniape xeniape added this pull request to the merge queue Sep 17, 2025
Merged via the queue into main with commit e1cb0e1 Sep 17, 2025
3 checks passed
@xeniape xeniape deleted the chore/vector-update-version-for-25.11 branch September 17, 2025 16:20
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Sep 19, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants