Skip to content

Conversation

Techassi
Copy link
Member

@siegfriedweber recently found out that it is currently not possible to specify a port for the registry host. This PR adds support for this.

Tested with

cargo boil build opa=1.4.2 --registry localhost:8080
# ...
Successfully built 1 image:
localhost:8080/sdp/opa:1.4.2-stackable0.0.0-dev-amd64

@Techassi Techassi self-assigned this Sep 26, 2025
@Techassi Techassi moved this to Development: Waiting for Review in Stackable Engineering Sep 26, 2025
@siegfriedweber siegfriedweber self-requested a review September 26, 2025 13:12
@siegfriedweber siegfriedweber moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Sep 26, 2025
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only nitpickings

Isn't there a changelog for boil? There should be one!

@Techassi
Copy link
Member Author

Techassi commented Sep 26, 2025

Isn't there a changelog for boil? There should be one!

No there currently isn't one, and I agree: there should be one. This passed my mind multiple times already. I will add one in a separate PR.

@Techassi Techassi added this pull request to the merge queue Sep 29, 2025
Merged via the queue into main with commit 850ece9 Sep 29, 2025
9 checks passed
@Techassi Techassi deleted the feat/boil-support-host-port branch September 29, 2025 06:54
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Sep 29, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants