Update getting-started.adoc - set zookeeper cli port #732
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Techassi
reviewed
Apr 17, 2025
Co-authored-by: Techassi <[email protected]>
Co-authored-by: Techassi <[email protected]>
nightkr
reviewed
May 6, 2025
|
|
||
| [source,bash] | ||
| ---- | ||
| kubectl exec -i -t simple-zk-server-primary-0 -- bin/zkCli.sh | ||
| # optional, determine the port | ||
| PORT=$(kubectl get pod simple-zk-server-primary-0 -o=jsonpath='{.spec.containers[0].ports[0].containerPort}') |
There was a problem hiding this comment.
Hm.. I don't think we should assume the order of the containers or ports. If we use jq we can decouple from that.
Suggested change
| PORT=$(kubectl get pod simple-zk-server-primary-0 -o=jsonpath='{.spec.containers[0].ports[0].containerPort}') | |
| PORT="$(kubectl get pod simple-zk-server-primary-0 -o=json | jq '.spec.containers[].ports[] | select(.name == "zk") | .containerPort')" |
There was a problem hiding this comment.
Yeah, jq might be the better alternative. The idea was just to use the kubectl builtin features to keep it simple. If the order could change i would also prefer jq.
Comment on lines
+238
to
+243
| We can test ZooKeeper by running the ZooKeeper CLI shell. The easiest way to do this is to run the CLI shell on the pod that is running ZooKeeper. It might be necessary to determine and set the port. | ||
|
|
||
| [source,bash] | ||
| ---- | ||
| kubectl exec -i -t simple-zk-server-primary-0 -- bin/zkCli.sh | ||
| # optional, determine the port |
There was a problem hiding this comment.
We don't need to tell people to do the wrong thing first, might as well just do the correct thing immediately.
Suggested change
| We can test ZooKeeper by running the ZooKeeper CLI shell. The easiest way to do this is to run the CLI shell on the pod that is running ZooKeeper. It might be necessary to determine and set the port. | |
| [source,bash] | |
| ---- | |
| kubectl exec -i -t simple-zk-server-primary-0 -- bin/zkCli.sh | |
| # optional, determine the port | |
| We can test ZooKeeper by running the ZooKeeper CLI shell. The easiest way to do this is to run the CLI shell on the pod that is running ZooKeeper. | |
| [source,bash] | |
| ---- |
|
|
||
| [source,bash] | ||
| ---- | ||
| kubectl exec -i -t simple-zk-server-primary-0 -- bin/zkCli.sh | ||
| # optional, determine the port | ||
| PORT=$(kubectl get pod simple-zk-server-primary-0 -o=jsonpath='{.spec.containers[0].ports[0].containerPort}') | ||
| echo $PORT |
There was a problem hiding this comment.
Don't think we need to print this out, to be honest.
Suggested change
| echo $PORT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my case the default port was not correct, leading to an error: