[Merged by Bors] - Changes needed to prepare crate to be compatible with crate2nix #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In stackabletech/operator-templating#212 we are planning to add a more developer friendly workflow for building and deploying artifacts to Kubernetes during development. This workflow uses crate2nix, which uses rustc directly and does not provide all environment variables required by the built crate we use (see nix-community/crate2nix#158). The content of these PR are the fixes needed to work around those limitations.
soenkeliebau
added a commit
to stackabletech/documentation
that referenced
this pull request
Feb 12, 2023
…the docs. For implementation, see: - stackabletech/operator-templating#212 - stackabletech/hdfs-operator#312
This was referenced Feb 12, 2023
nightkr
approved these changes
Feb 13, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 13, 2023
# Description In stackabletech/operator-templating#212 we are planning to add a more developer friendly workflow for building and deploying artifacts to Kubernetes during development. This workflow uses crate2nix, which uses rustc directly and does not provide all environment variables required by the built crate we use (see nix-community/crate2nix#158). The content of these PR are the fixes needed to work around those limitations.
|
Canceled. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 13, 2023
# Description In stackabletech/operator-templating#212 we are planning to add a more developer friendly workflow for building and deploying artifacts to Kubernetes during development. This workflow uses crate2nix, which uses rustc directly and does not provide all environment variables required by the built crate we use (see nix-community/crate2nix#158). The content of these PR are the fixes needed to work around those limitations. Co-authored-by: Sönke Liebau <[email protected]>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
soenkeliebau
added a commit
to stackabletech/documentation
that referenced
this pull request
Feb 14, 2023
…the docs (#360) * Adds explanation of crate2nix and tilt based development workflow to the docs. For implementation, see: - stackabletech/operator-templating#212 - stackabletech/hdfs-operator#312 Co-authored-by: Natalie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In stackabletech/operator-templating#212 we are planning to add a more developer friendly workflow for building and deploying artifacts to Kubernetes during development.
This workflow uses crate2nix, which uses rustc directly and does not provide all environment variables required by the built crate we use (see nix-community/crate2nix#158). The content of these PR are the fixes needed to work around those limitations.
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information