Listener: Use headless and metrics service #613
+183
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maleware
changed the title
Maleware
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
maltesander
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
maltesander
requested changes
Jul 3, 2025
rust/operator-binary/src/crd/mod.rs
Outdated
| @@ -246,6 +246,43 @@ impl v1alpha1::HiveCluster { | |||
| format!("{name}-{role}", name = self.name_any(), role = hive_role) | |||
| } | |||
|
|
|||
| /// Set of functions to define service names on rolegroup level. | |||
There was a problem hiding this comment.
Not really useful and belongs to this method only.
Suggested change
| /// Set of functions to define service names on rolegroup level. |
| selector: Some( | ||
| Labels::role_group_selector(hive, APP_NAME, &rolegroup.role, &rolegroup.role_group) | ||
| ) -> Result<Vec<Service>> { | ||
| let services = vec![ |
There was a problem hiding this comment.
Can we move this to a service.rs module and put the two services in its own methods?
rust/operator-binary/src/crd/mod.rs
Outdated
Comment on lines
250
to
284
| /// Headless service for cluster internal purposes only. | ||
| // TODO: Move to operator-rs | ||
| pub fn rolegroup_headless_service_name( | ||
| &self, | ||
| rolegroup: &RoleGroupRef<v1alpha1::HiveCluster>, | ||
| ) -> String { | ||
| format!("{name}-headless", name = rolegroup.object_name()) | ||
| } | ||
|
|
||
| /// Headless metrics service exposes Prometheus endpoint only | ||
| // TODO: Move to operator-rs | ||
| pub fn rolegroup_headless_metrics_service_name( | ||
| &self, | ||
| rolegroup: &RoleGroupRef<v1alpha1::HiveCluster>, | ||
| ) -> String { | ||
| format!("{name}-metrics", name = rolegroup.object_name()) | ||
| } | ||
|
|
||
| pub fn metrics_ports(&self) -> Vec<ServicePort> { | ||
| vec![ServicePort { | ||
| name: Some(METRICS_PORT_NAME.to_string()), | ||
| port: METRICS_PORT.into(), | ||
| protocol: Some("TCP".to_string()), | ||
| ..ServicePort::default() | ||
| }] | ||
| } | ||
|
|
||
| pub fn service_ports(&self) -> Vec<ServicePort> { | ||
| vec![ServicePort { | ||
| name: Some(HIVE_PORT_NAME.to_string()), | ||
| port: HIVE_PORT.into(), | ||
| protocol: Some("TCP".to_string()), | ||
| ..ServicePort::default() | ||
| }] | ||
| } |
There was a problem hiding this comment.
This should not be implemented on the cluster (does not need self) and could go into a service.rs module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adopts hive according to https://github.com/stackabletech/decisions/issues/54#issue-3110829918
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker