Skip to content

feat: OPA Authorizer #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
May 21, 2025
Merged

feat: OPA Authorizer #777

merged 36 commits into from
May 21, 2025

Conversation

labrenbe
Copy link
Member

@labrenbe labrenbe commented Apr 15, 2025

Description

Adds support for authorization with OPA using Nifi OPA Plugin .

Tests passen on Openshift

--- PASS: kuttl (961.58s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/oidc-opa_nifi-1.28.1_zookeeper-latest-3.9.3_opa-latest-1.0.1_oidc-use-tls-true_openshift-false (406.42s)
        --- PASS: kuttl/harness/oidc-opa_nifi-1.27.0_zookeeper-latest-3.9.3_opa-latest-1.0.1_oidc-use-tls-false_openshift-false (418.03s)
        --- PASS: kuttl/harness/oidc-opa_nifi-1.28.1_zookeeper-latest-3.9.3_opa-latest-1.0.1_oidc-use-tls-false_openshift-false (249.60s)
        --- PASS: kuttl/harness/oidc-opa_nifi-2.4.0_zookeeper-latest-3.9.3_opa-latest-1.0.1_oidc-use-tls-true_openshift-false (267.88s)
        --- PASS: kuttl/harness/oidc-opa_nifi-2.4.0_zookeeper-latest-3.9.3_opa-latest-1.0.1_oidc-use-tls-false_openshift-false (217.25s)
        --- PASS: kuttl/harness/oidc-opa_nifi-1.27.0_zookeeper-latest-3.9.3_opa-latest-1.0.1_oidc-use-tls-true_openshift-false (265.99s)
PASS

Should not be merged before: stackabletech/docker-images#1058

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [X] Changes are OpenShift compatible
- [X] CRD changes approved
- [X] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [X] Helm chart can be installed and deployed operator works
- [X] Integration tests passed (for non trivial changes)
- [X] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@labrenbe labrenbe self-assigned this Apr 15, 2025
@labrenbe labrenbe marked this pull request as ready for review April 15, 2025 08:54
@labrenbe labrenbe linked an issue Apr 22, 2025 that may be closed by this pull request
@maltesander maltesander self-requested a review April 22, 2025 14:57
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first batch of comments

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should already prepare a more extensive test environment.
Meaning having a couple of users in keycloak with different access in the regos that can be tested via API and easily extended?

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@labrenbe labrenbe added this pull request to the merge queue May 21, 2025
Merged via the queue into main with commit 1590b98 May 21, 2025
17 checks passed
@labrenbe labrenbe deleted the feat/opa-authorizer branch May 21, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a NiFi Authorizer that interfaces with OPA
2 participants