Skip to content

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Sep 22, 2025

Description

Part of stackabletech/docker-images#1233

Integrationtests

--- PASS: kuttl (101.92s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/logging_opa-1.4.2_openshift-false (100.05s)
        --- PASS: kuttl/harness/logging_opa-1.0.1_openshift-false (101.91s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@xeniape xeniape self-assigned this Sep 22, 2025
@xeniape xeniape moved this to Development: Waiting for Review in Stackable Engineering Sep 22, 2025
@adwk67 adwk67 self-requested a review September 22, 2025 13:29
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Sep 22, 2025
sbernauer
sbernauer previously approved these changes Sep 22, 2025
@sbernauer sbernauer self-requested a review September 22, 2025 13:44
@sbernauer sbernauer dismissed their stale review September 22, 2025 13:44

Andrew wants to review

adwk67
adwk67 previously approved these changes Sep 22, 2025
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not part of this PR, but this line should reference test-opa-server and not test-opa. Shall we correct that quickly here, or open a new PR?

@xeniape
Copy link
Member Author

xeniape commented Sep 22, 2025

LGTM! Not part of this PR, but this line should reference test-opa-server and not test-opa. Shall we correct that quickly here, or open a new PR?

I can fix it here, no problem. But shouldn't the test have failed then? Or are both services present?

@adwk67
Copy link
Member

adwk67 commented Sep 22, 2025

LGTM! Not part of this PR, but this line should reference test-opa-server and not test-opa. Shall we correct that quickly here, or open a new PR?

I can fix it here, no problem. But shouldn't the test have failed then? Or are both services present?

In the shell script version, the test failed before the test-check bit was reached! We'd updated the name of the service in the python test, but not in the shell script one.

Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xeniape xeniape added this pull request to the merge queue Sep 22, 2025
Merged via the queue into main with commit ec2fc7a Sep 22, 2025
17 checks passed
@xeniape xeniape deleted the chore/bump-vector-version-for-25.11.0 branch September 22, 2025 15:08
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: Done
Development

Successfully merging this pull request may close these issues.

3 participants