-
-
Notifications
You must be signed in to change notification settings - Fork 4
chore: Bump vector version for 25.11.0 #763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Not part of this PR, but this line should reference test-opa-server
and not test-opa
. Shall we correct that quickly here, or open a new PR?
I can fix it here, no problem. But shouldn't the test have failed then? Or are both services present? |
In the shell script version, the test failed before the test-check bit was reached! We'd updated the name of the service in the python test, but not in the shell script one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
Part of stackabletech/docker-images#1233
Integrationtests
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecation
label & add to the deprecation scheduletype/experimental
label & add to the experimental features tracker