Skip to content

feat: Make OPENSEARCH_HOME and OPENSEARCH_PATH_CONF overridable #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2025

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Jul 31, 2025

Description

Make OPENSEARCH_HOME and OPENSEARCH_PATH_CONF overridable

In the early development phase of the operator, it is extremly useful, to be able to use the official product image. On the one hand, different behaviors can be tested, on the other hand, other product versions like OpenSearch 2.x can be tested where no Stackable image exists.

Part of #2

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@siegfriedweber siegfriedweber self-assigned this Jul 31, 2025
@siegfriedweber siegfriedweber mentioned this pull request Jul 24, 2025
19 tasks
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't have run the tests but this is LGTM assuming you have done so!
Update: local tests all good

Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG is missing

Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@siegfriedweber siegfriedweber added this pull request to the merge queue Jul 31, 2025
Merged via the queue into main with commit c48fadf Jul 31, 2025
15 checks passed
@siegfriedweber siegfriedweber deleted the fix/technical-debts branch July 31, 2025 10:14
@siegfriedweber
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants