-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Make OPENSEARCH_HOME and OPENSEARCH_PATH_CONF overridable #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't have run the tests but this is LGTM assuming you have done so!
Update: local tests all good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CHANGELOG is missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
Make
OPENSEARCH_HOME
andOPENSEARCH_PATH_CONF
overridableIn the early development phase of the operator, it is extremly useful, to be able to use the official product image. On the one hand, different behaviors can be tested, on the other hand, other product versions like OpenSearch 2.x can be tested where no Stackable image exists.
Part of #2
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecation
label & add to the deprecation scheduletype/experimental
label & add to the experimental features tracker