feat: Include Spark connect in stacklet list #380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also uncovered two bugs:
app.kubernetes.io/name=spark-connect,app.kubernetes.io/instance=spark-connect
undapp.kubernetes.io/name=spark-history,app.kubernetes.io/instance=spark-history
match nothing. We should setapp.kubernetes.io/name=spark-connect
instead of currentlyapp.kubernetes.io/name: spark-k8s
(same for HistoryServer)I pinged @razvan about the bugs, once they are fixed everything should work
=> He created stackabletech/spark-k8s-operator#573
Definition of Done Checklist