Skip to content

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Sep 26, 2025

Description

fixes stackabletech/docker-images#1241

  • 4.0.2 marked as deprecated.
  • Retained in tests/test-definition.yaml.
  • Updated changelog
  • No other occurences of "4.0.2" in the code.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67 adwk67 moved this to Development: Waiting for Review in Stackable Engineering Sep 26, 2025
@adwk67 adwk67 self-assigned this Sep 26, 2025
@maltesander maltesander self-requested a review September 29, 2025 06:07
@maltesander maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Sep 29, 2025
@maltesander
Copy link
Member

Its still in the tests. I dont think it makes sense to continue testing 4.0.2?

@adwk67
Copy link
Member Author

adwk67 commented Sep 29, 2025

Its still in the tests. I dont think it makes sense to continue testing 4.0.2?

Don't we test all the supported versions in the weekly tests?

@maltesander
Copy link
Member

maltesander commented Sep 29, 2025

Theres no policy i guess, but i dont see the point. Its removed for next release, dev versions are basically a preview and not recommended, so why spend the ressources :) ?

Edit: I think im wrong, its deprecated next release, removed the release after?

@adwk67
Copy link
Member Author

adwk67 commented Sep 29, 2025

b9fe0c4

Fair enough 👍 I've removed it: b9fe0c4

@adwk67 adwk67 enabled auto-merge September 29, 2025 07:25
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adwk67 adwk67 added this pull request to the merge queue Sep 29, 2025
Merged via the queue into main with commit ae211cf Sep 29, 2025
17 checks passed
@adwk67 adwk67 deleted the chore/deprecate-4.0.2 branch September 29, 2025 07:41
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Sep 29, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

chore(superset): Update major/minor versions for 25.11.0

2 participants