Skip to content

stg pull on a branch without upstream set is causing an Exception #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NonLogicalDev opened this issue Nov 20, 2020 · 1 comment · Fixed by #84
Closed

stg pull on a branch without upstream set is causing an Exception #83

NonLogicalDev opened this issue Nov 20, 2020 · 1 comment · Fixed by #84

Comments

@NonLogicalDev
Copy link
Contributor

NonLogicalDev commented Nov 20, 2020

If a particular branch does not have tracking information spits out traceback.

Traceback (most recent call last):
  File "/Users/<USER>/Documents/Developer/stgit/stgit/main.py", line 188, in _main
    ret = command.func(parser, options, args)
  File "/Users/<USER>/Documents/Developer/stgit/stgit/commands/pull.py", line 137, in func
    pull(repository, remote_name)
  File "/Users/<USER>/Documents/Developer/stgit/stgit/commands/pull.py", line 78, in pull
    runner.returns([0, 1]).run()
  File "/Users/<USER>/Documents/Developer/stgit/stgit/run.py", line 265, in run
    self._run_noio()
  File "/Users/<USER>/Documents/Developer/stgit/stgit/run.py", line 161, in _run_noio
    self._prep_cmd(),
  File "/Users/<USER>/Documents/Developer/stgit/stgit/run.py", line 88, in _prep_cmd
    return [fsencode_utf8(c) for c in self._cmd]
  File "/Users/<USER>/Documents/Developer/stgit/stgit/run.py", line 88, in <listcomp>
    return [fsencode_utf8(c) for c in self._cmd]
  File "/Users/<USER>/Documents/Developer/stgit/stgit/compat.py", line 28, in fsencode_utf8
    return os.fsencode(s)
  File "/usr/local/opt/[email protected]/bin/../Frameworks/Python.framework/Versions/3.8/lib/python3.8/os.py", line 806, in fsencode
    filename = fspath(filename)  # Does type-checking of `filename`.
TypeError: expected str, bytes or os.PathLike object, not NoneType
@NonLogicalDev
Copy link
Contributor Author

@jpgrayson this is a fairly straightforward fix

NonLogicalDev added a commit to NonLogicalDev/fork.stgit that referenced this issue Nov 24, 2020
NonLogicalDev added a commit to NonLogicalDev/fork.stgit that referenced this issue Nov 24, 2020
jpgrayson pushed a commit that referenced this issue Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant