Skip to content

RT-538: NetStandard 2.0 #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions Src/CoreConsoleApp/CoreConsoleApp.csproj
Original file line number Diff line number Diff line change
@@ -1,31 +1,39 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netcoreapp1.0</TargetFramework>
<TargetFramework>netcoreapp2.0</TargetFramework>
<AssemblyName>CoreConsoleApp</AssemblyName>
<OutputType>Exe</OutputType>
<PackageId>CoreConsoleApp</PackageId>
<RuntimeIdentifiers>win10-x64</RuntimeIdentifiers>
<RuntimeFrameworkVersion>1.0.4</RuntimeFrameworkVersion>
<PackageTargetFallback>$(PackageTargetFallback);dnxcore50</PackageTargetFallback>
<RuntimeFrameworkVersion>2.0.0</RuntimeFrameworkVersion>
<GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>
<GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
<GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\StackifyLib.log4net\StackifyLib.log4net.csproj" />
<ProjectReference Include="..\StackifyLib\StackifyLib.csproj" />
<ProjectReference Include="..\NLog.Targets.Stackify\NLog.Targets.Stackify.csproj" />
<ProjectReference Include="..\StackifyLib.log4net\StackifyLib.log4net.csproj" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="log4net" Version="2.0.7" />
<PackageReference Include="Microsoft.Extensions.Configuration" Version="2.0.0" />
<PackageReference Include="Microsoft.Extensions.Configuration.FileExtensions" Version="2.0.0" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="2.0.0" />
<PackageReference Include="NLog" Version="4.5.0-rc02" />
<PackageReference Include="Serilog" Version="2.4.0" />
<PackageReference Include="Microsoft.Extensions.Configuration" Version="1.1.1" />
<PackageReference Include="Microsoft.Extensions.Configuration.FileExtensions" Version="1.1.1" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="1.1.1" />
<PackageReference Include="System.Net.NameResolution" Version="4.3.0" />
<PackageReference Include="System.Net.Sockets" Version="4.3.0" />
</ItemGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
<DefineConstants>NETCORE</DefineConstants>
</PropertyGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'net40' OR '$(TargetFramework)' == 'net45' OR '$(TargetFramework)' == 'net451' OR '$(TargetFramework)' == 'net452' OR '$(TargetFramework)' == 'net46' ">
<DefineConstants>NETFULL</DefineConstants>
</PropertyGroup>

</Project>
3 changes: 1 addition & 2 deletions Src/CoreConsoleApp/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ static void Main(string[] args)
{
var builder = new ConfigurationBuilder()
.SetBasePath(Directory.GetCurrentDirectory())
.AddJsonFile("appsettings.json", optional: true,
reloadOnChange: true);
.AddJsonFile("appsettings.json", optional: true, reloadOnChange: true);

var config = builder.Build();
config.ConfigureStackifyLogging();
Expand Down
31 changes: 17 additions & 14 deletions Src/CoreWebApp/CoreWebApp.csproj
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
<Project Sdk="Microsoft.NET.Sdk.Web">

<PropertyGroup>
<TargetFramework>netcoreapp1.0</TargetFramework>
<TargetFramework>netcoreapp2.0</TargetFramework>
<PreserveCompilationContext>true</PreserveCompilationContext>
<AssemblyName>CoreWebApp</AssemblyName>
<OutputType>Exe</OutputType>
<PackageId>CoreWebApp</PackageId>
<RuntimeFrameworkVersion>1.0.4</RuntimeFrameworkVersion>
<PackageTargetFallback>$(PackageTargetFallback);dotnet5.6;portable-net45+win8</PackageTargetFallback>
<RuntimeFrameworkVersion>2.0.0</RuntimeFrameworkVersion>
</PropertyGroup>

<ItemGroup>
Expand All @@ -25,22 +24,26 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Mvc" Version="1.0.3" />
<PackageReference Include="Microsoft.AspNetCore.Routing" Version="1.0.3" />
<PackageReference Include="Microsoft.AspNetCore.Server.IISIntegration" Version="1.0.2" />
<PackageReference Include="Microsoft.AspNetCore.Server.Kestrel" Version="1.0.3" />
<PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="1.0.2" />
<PackageReference Include="Microsoft.Extensions.Configuration.FileExtensions" Version="1.0.2" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="1.0.2" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="1.0.2" />
<PackageReference Include="Microsoft.Extensions.Logging.Console" Version="1.0.2" />
<PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="1.0.2" />
<PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="1.0.2" />
<PackageReference Include="Microsoft.AspNetCore" Version="2.0.1" />
<PackageReference Include="Microsoft.AspNetCore.All" Version="2.0.3" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.Core" Version="2.0.1" />
<PackageReference Include="Microsoft.AspNetCore.Server.Kestrel" Version="2.0.1" />
<PackageReference Include="Microsoft.Extensions.Configuration" Version="2.0.0" />
<PackageReference Include="Microsoft.Extensions.Configuration.FileExtensions" Version="2.0.0" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="2.0.0" />
<PackageReference Include="NLog" Version="4.5.0-rc02" />
<PackageReference Include="NLog.Extensions.Logging" Version="1.0.0-rtm-rc4" />
<PackageReference Include="Serilog" Version="2.4.0" />
<PackageReference Include="Serilog.Extensions.Logging" Version="1.4.0" />
<PackageReference Include="Serilog.Extensions.Logging.File" Version="1.0.0" />
</ItemGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
<DefineConstants>NETCORE</DefineConstants>
</PropertyGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'net40' OR '$(TargetFramework)' == 'net45' OR '$(TargetFramework)' == 'net451' OR '$(TargetFramework)' == 'net452' OR '$(TargetFramework)' == 'net46' ">
<DefineConstants>NETFULL</DefineConstants>
</PropertyGroup>

</Project>
22 changes: 10 additions & 12 deletions Src/NLog.Targets.Stackify/NLog.Targets.Stackify.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<AssemblyTitle>NLog.Targets.Stackify</AssemblyTitle>
<VersionPrefix>2.0.0</VersionPrefix>
<TargetFrameworks>netstandard1.5;net40;net45</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net40;net45;net451;net452;net46</TargetFrameworks>
<AssemblyName>NLog.Targets.Stackify</AssemblyName>
<PackageId>NLog.Targets.Stackify</PackageId>
<PackageTags>stackify;errors;logs</PackageTags>
Expand All @@ -15,7 +15,7 @@
<GenerateAssemblyCopyrightAttribute>false</GenerateAssemblyCopyrightAttribute>
<GenerateAssemblyVersionAttribute>false</GenerateAssemblyVersionAttribute>
<GenerateAssemblyFileVersionAttribute>false</GenerateAssemblyFileVersionAttribute>
<Version>2.0.2</Version>
<Version>2.1.0</Version>
<PackageLicenseUrl>https://github.com/stackify/stackify-api-dotnet/blob/master/LICENSE</PackageLicenseUrl>
<PackageProjectUrl>https://github.com/stackify/stackify-api-dotnet</PackageProjectUrl>
<PackageIconUrl>https://stackify.com/wp-content/uploads/2017/02/stk.png</PackageIconUrl>
Expand All @@ -26,21 +26,19 @@
<ItemGroup>
<ProjectReference Include="..\StackifyLib\StackifyLib.csproj" />
</ItemGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
<DefineConstants>NETCORE</DefineConstants>
</PropertyGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard1.5' ">
<ItemGroup>
<PackageReference Include="NLog" Version="4.5.0-rc02" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net40' ">
<PackageReference Include="NLog" Version="4.3.11" />
<Reference Include="System" />
<Reference Include="Microsoft.CSharp" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net45' ">
<PackageReference Include="NLog" Version="4.3.11" />
<Reference Include="System" />
<Reference Include="Microsoft.CSharp" />
</ItemGroup>
<PropertyGroup Condition=" '$(TargetFramework)' == 'net40' OR '$(TargetFramework)' == 'net45' OR '$(TargetFramework)' == 'net451' OR '$(TargetFramework)' == 'net452' OR '$(TargetFramework)' == 'net46' ">
<DefineConstants>NETFULL</DefineConstants>
</PropertyGroup>

</Project>
4 changes: 2 additions & 2 deletions Src/NLog.Targets.Stackify/StackifyTarget.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
using System.Globalization;
using System.Linq;
using System.Reflection;
#if NET45 || NET40
#if NETFULL
using System.Runtime.Remoting.Messaging;
#endif
using StackifyLib;
Expand Down Expand Up @@ -145,7 +145,7 @@ private Dictionary<string, object> GetDiagnosticContextProperties()
}
}

#if NET45 || NET40
#if NETFULL

foreach (string key in _CallContextKeys)
{
Expand Down
31 changes: 9 additions & 22 deletions Src/StackifyLib.AspNetCore/StackifyLib.AspNetCore.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,14 @@
<PropertyGroup>
<AssemblyTitle>StackifyLib for AspNetCore</AssemblyTitle>
<VersionPrefix>2.0.0</VersionPrefix>
<TargetFrameworks>netstandard1.3;net451</TargetFrameworks>
<TargetFramework>netstandard2.0</TargetFramework>
<AssemblyName>StackifyLib.AspNetCore</AssemblyName>
<PackageId>StackifyLib.AspNetCore</PackageId>
<PackageTags>stackify;metrics;errors;logs</PackageTags>
<NetStandardImplicitPackageVersion>1.6.1</NetStandardImplicitPackageVersion>
<PackageTargetFallback>$(PackageTargetFallback);dnxcore50</PackageTargetFallback>
<GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>
<GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
<GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
<Version>2.0.1</Version>
<Version>2.1.0</Version>
<Description>StackifyLib.AspNetCore</Description>
<PackageLicenseUrl>https://github.com/stackify/stackify-api-dotnet/blob/master/LICENSE</PackageLicenseUrl>
<PackageProjectUrl>https://github.com/stackify/stackify-api-dotnet</PackageProjectUrl>
Expand All @@ -25,25 +23,14 @@
<ProjectReference Include="..\StackifyLib\StackifyLib.csproj" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard1.3' ">
<PackageReference Include="Microsoft.Extensions.Configuration" Version="1.1.1" />
<PackageReference Include="System.ComponentModel" Version="4.3.0" />
<PackageReference Include="Microsoft.AspNetCore.Http.Abstractions" Version="1.0.2" />
<PackageReference Include="Microsoft.AspNetCore.Http.Extensions" Version="1.0.2" />
<PackageReference Include="Microsoft.AspNetCore.Hosting" Version="1.0.2" />
<PackageReference Include="Microsoft.AspNetCore.Hosting.Abstractions" Version="1.0.2" />
<PackageReference Include="Microsoft.AspNetCore.Routing" Version="1.0.3" />
</ItemGroup>


<ItemGroup Condition=" '$(TargetFramework)' == 'net451' ">
<PackageReference Include="Microsoft.Extensions.Configuration" Version="1.1.1" />
<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Configuration" Version="2.0.0" />
<PackageReference Include="System.ComponentModel" Version="4.3.0" />
<PackageReference Include="Microsoft.AspNetCore.Http.Abstractions" Version="1.0.2" />
<PackageReference Include="Microsoft.AspNetCore.Http.Extensions" Version="1.0.2" />
<PackageReference Include="Microsoft.AspNetCore.Hosting" Version="1.0.2" />
<PackageReference Include="Microsoft.AspNetCore.Hosting.Abstractions" Version="1.0.2" />
<PackageReference Include="Microsoft.AspNetCore.Routing" Version="1.0.3" />
<PackageReference Include="Microsoft.AspNetCore.Http.Abstractions" Version="2.0.1" />
<PackageReference Include="Microsoft.AspNetCore.Http.Extensions" Version="2.0.1" />
<PackageReference Include="Microsoft.AspNetCore.Hosting" Version="2.0.1" />
<PackageReference Include="Microsoft.AspNetCore.Hosting.Abstractions" Version="2.0.1" />
<PackageReference Include="Microsoft.AspNetCore.Routing" Version="2.0.1" />
</ItemGroup>

</Project>
16 changes: 4 additions & 12 deletions Src/StackifyLib.CoreLogger/StackifyLib.CoreLogger.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,10 @@
<PropertyGroup>
<AssemblyTitle>Stackify .NET Core LoggerFactory</AssemblyTitle>
<VersionPrefix>2.0.0</VersionPrefix>
<TargetFrameworks>netstandard1.3;net45</TargetFrameworks>
<TargetFramework>netstandard2.0</TargetFramework>
<AssemblyName>StackifyLib.CoreLogger</AssemblyName>
<PackageId>StackifyLib.CoreLogger</PackageId>
<PackageTags>stackify;metrics;errors;logs</PackageTags>
<NetStandardImplicitPackageVersion>1.6.1</NetStandardImplicitPackageVersion>
<PackageTargetFallback>$(PackageTargetFallback);dnxcore50</PackageTargetFallback>
<GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>
<GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
<GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
Expand All @@ -18,22 +16,16 @@
<RepositoryType>git</RepositoryType>
<PackageIconUrl>https://stackify.com/wp-content/uploads/2017/02/stk.png</PackageIconUrl>
<Description>StackifyLib.CoreLogger</Description>
<Version>2.0.2</Version>
<Version>2.1.0</Version>
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\StackifyLib\StackifyLib.csproj" />
</ItemGroup>


<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard1.3' ">
<PackageReference Include="Microsoft.Extensions.Logging" Version="1.0.2" />
</ItemGroup>


<ItemGroup Condition=" '$(TargetFramework)' == 'net45' ">
<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Logging" Version="1.0.2" />
</ItemGroup>


</Project>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,13 @@

<PropertyGroup>
<VersionPrefix>2.0.0</VersionPrefix>
<TargetFrameworks>netstandard1.3;net45</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net40;net45;net451;net452;net46</TargetFrameworks>
<AssemblyName>StackifyLib.StackifyTraceListener</AssemblyName>
<PackageId>StackifyLib.StackifyTraceListener</PackageId>
<PackageTargetFallback Condition=" '$(TargetFramework)' == 'netstandard1.3' ">$(PackageTargetFallback);dnxcore50</PackageTargetFallback>
<GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>
<GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
<GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
<Version>2.0.1</Version>
<Version>2.1.0</Version>
<Description>StackifyLib.StackifyTraceListener</Description>
<PackageLicenseUrl>https://github.com/stackify/stackify-api-dotnet/blob/master/LICENSE</PackageLicenseUrl>
<PackageProjectUrl>https://github.com/stackify/stackify-api-dotnet</PackageProjectUrl>
Expand All @@ -22,12 +21,7 @@
<ProjectReference Include="..\StackifyLib\StackifyLib.csproj" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard1.3' ">
<PackageReference Include="System.Diagnostics.TraceSource" Version="4.0.0" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net45' ">
<Reference Include="System" />
<ItemGroup>
<Reference Include="Microsoft.CSharp" />
</ItemGroup>

Expand Down
4 changes: 1 addition & 3 deletions Src/StackifyLib.log4net/StackifyAppender.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
using Apache_log4net = log4net;
using log4net.Appender;
using log4net.Core;
using log4netOffical = log4net;


namespace StackifyLib.log4net
{
Expand Down Expand Up @@ -323,7 +321,7 @@ private Dictionary<string, object> GetDiagnosticContextProperties()
}
}
}
#if NET45
#if NETFULL
foreach (string mdcKey in _LogicalThreadContextKeys)
{
object mdcValue = Apache_log4net.LogicalThreadContext.Properties[mdcKey];
Expand Down
27 changes: 12 additions & 15 deletions Src/StackifyLib.log4net/StackifyLib.log4net.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<AssemblyTitle>Stackify Log4Net Appender</AssemblyTitle>
<VersionPrefix>2.0.0</VersionPrefix>
<TargetFrameworks>netstandard1.3;net40;net45</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net40;net45</TargetFrameworks>
<AssemblyName>StackifyLib.log4net</AssemblyName>
<PackageId>StackifyLib.log4net</PackageId>
<PackageTags>stackify;metrics;errors;logs</PackageTags>
Expand All @@ -13,7 +13,7 @@
<GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
<GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
<GenerateAssemblyCopyrightAttribute>false</GenerateAssemblyCopyrightAttribute>
<Version>2.0.1</Version>
<Version>2.1.0</Version>
<PackageLicenseUrl>https://github.com/stackify/stackify-api-dotnet/blob/master/LICENSE</PackageLicenseUrl>
<PackageProjectUrl>https://github.com/stackify/stackify-api-dotnet</PackageProjectUrl>
<RepositoryUrl>https://github.com/stackify/stackify-api-dotnet</RepositoryUrl>
Expand All @@ -25,20 +25,17 @@
<ProjectReference Include="..\StackifyLib\StackifyLib.csproj" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard1.3' ">
<PackageReference Include="log4net" Version="2.0.7" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net40' ">
<PackageReference Include="log4net" Version="2.0.5" />
<Reference Include="System" />
<Reference Include="Microsoft.CSharp" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net45' ">
<PackageReference Include="log4net" Version="2.0.5" />
<Reference Include="System" />
<ItemGroup>
<PackageReference Include="log4net" Version="2.0.8" />
<Reference Include="Microsoft.CSharp" />
</ItemGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
<DefineConstants>NETCORE</DefineConstants>
</PropertyGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'net40' OR '$(TargetFramework)' == 'net45' ">
<DefineConstants>NETFULL</DefineConstants>
</PropertyGroup>

</Project>
2 changes: 1 addition & 1 deletion Src/StackifyLib.log4net/packages.config
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="log4net" version="2.0.0" targetFramework="net40" />

</packages>
Loading