This repository was archived by the owner on Feb 13, 2025. It is now read-only.
WIP: Stackless issue #202: remove the STACKLESS_DECLARE_METHOD magic #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Now that we have C99 designated initializers, we don't need the STACKLESS_DECLARE_METHOD magic any longer. Replacing it with explicit initializers has several advantages: - faster startup time - less magic, code is simpler to reason about - no memory leak - no initialization race for sub-types between init_stackless_methods() and PyType_Ready().
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have C99 designated initializers, we don't need the
STACKLESS_DECLARE_METHOD magic any longer. Replacing it with explicit
initializers has several advantages:
and PyType_Ready().
Of this pull request only the commit 5c7a4dd and its children are relevant. This pull request must be merged only after pull requests #188 and #201 have been merged.