Skip to content

chore: security updates for dependencies #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jtroup
Copy link
Contributor

@jtroup jtroup commented Aug 6, 2025

what

  • Update dependencies for security updates
  • Switch to python 3.12 in pyproject.toml
  • Fix two spelling typos
  • script/upgrade.py: remove note about tomllib which doesn't support writing TOML files

why

Security and speeling.

testing

poetry install; just test

docs

N/A

 * Update dependencies for security updates
 * Switch to python 3.12 in pyproject.toml
 * Fix two spelling typos
 * script/upgrade.py: remove note about tomllib which doesn't support
   writing TOML files
@jtroup jtroup requested a review from a team as a code owner August 6, 2025 18:13
@jtroup
Copy link
Contributor Author

jtroup commented Aug 6, 2025

So... despite this passing the CI checks, this breaks support for Python << 3.12. The problem is urllib3 and cryptography are kept at older & vulnerable versions if we support python << 3.10. Not sure what the right trade off is here.

@jtroup jtroup marked this pull request as draft August 6, 2025 18:19
@sontek
Copy link
Contributor

sontek commented Aug 6, 2025

Yeah, I guess the concern is since this is a client tool we might be breaking customers utilization of it. I thought Python 3.9 was still in security support mode this year so in theory it should still be getting patches. So I guess its just that cryptography and urllib don't want to support it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants