feat: add resource for Microsoft Teams configuration profile [ENG-5591] #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ENG-5591](https://stacklet.atlassian.net/browse/ENG-5591) ### what add `stacklet_configuration_profile_teams` resource ### why support configuring Microsoft Teams integration ### testing sandbox testing, added acceptance tests ### docs updated here
albertodonato
force-pushed
the
ack/release-configuration-profile-resource-teams
branch
from
3be3a64 to
ea1f98d
Compare
fwereade
approved these changes
Aug 27, 2025
| return | ||
| } | ||
|
|
||
| names := models.ListItemsIdentifiers(state.Webhooks, "name") |
There was a problem hiding this comment.
maybe an explicit comment about how we're restoring the input ordering here?
(…and maybe this whole repeated block deserves a name of its own for that comment to hang off?)
albertodonato
deleted the
ack/release-configuration-profile-resource-teams
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENG-5591
what
add
stacklet_configuration_profile_teamsresourcewhy
support configuring Microsoft Teams integration
testing
sandbox testing, added acceptance tests
docs
updated here