This repository was archived by the owner on Jul 8, 2025. It is now read-only.
test: alerts summary cards #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alex-mcgovern
commented
Jan 29, 2025
alex-mcgovern
commented
- adds tests for alert summary cards
- slightly refactors how we mock things for alerts
Minder Vulnerability Report ✅Minder analyzed this PR and found it does not add any new vulnerable dependencies.
|
ghost
reviewed
Jan 29, 2025
There was a problem hiding this comment.
Dependency Information
Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.
📦 Dependency: @rollup/rollup-darwin-arm64
Trusty Score: 0
Scoring details
| Component | Score |
|---|---|
| Package activity | 9 |
| Repository activity | 8.5 |
| User activity | 9.6 |
| Provenance | historical_provenance_match |
Proof of Origin (Provenance)
This package can be linked back to its source code using a historical provenance map.
We were able to correlate a significant number of git tags and tagged releases in this package’s source code to versions of the published package. This mapping creates a strong link from the package back to its source code repository, verifying proof of origin.
| Published package versions | 112 |
| Number of git tags or releases | 203 |
| Versions matched to tags or releases | 89 |
Alternatives
| Package | Score | Description |
|---|---|---|
| @rollup/rollup-darwin-x64 | 0 | |
| @rollup/rollup-darwin-x64 | 0 |
peppescg
reviewed
Jan 29, 2025
package.json
Outdated
| @@ -9,7 +9,7 @@ | |||
| "generate-client": "npm run fetch-openapi-schema && npm run openapi-ts", | |||
| "fetch-openapi-schema": "curl https://github.com/raw/stacklok/codegate/refs/heads/main/api/openapi.json > src/api/openapi.json", | |||
| "openapi-ts": "openapi-ts", | |||
| "knip": "knip --production", | |||
| "knip": "knip", | |||
There was a problem hiding this comment.
I remember the same change in a previous PR 🤔
peppescg
approved these changes
Jan 29, 2025
Pull Request Test Coverage Report for Build 13034256305Details
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.