-
Notifications
You must be signed in to change notification settings - Fork 122
add support for propagating telemetry in configmap #1858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1858 +/- ##
==========================================
+ Coverage 42.34% 44.75% +2.40%
==========================================
Files 197 203 +6
Lines 25156 25920 +764
==========================================
+ Hits 10653 11600 +947
+ Misses 13667 13412 -255
- Partials 836 908 +72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dcedfee
to
5c726d0
Compare
43f9eac
to
8f312a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive support for propagating telemetry configuration through ConfigMaps in the operator system. When ConfigMap mode is enabled, telemetry configurations from MCPServer specs are now properly serialized into runconfig.json files and consumed by the proxyrunner instead of being passed as individual CLI arguments.
- Telemetry configuration is now included in ConfigMap runconfig.json when ConfigMap mode is enabled
- OpenTelemetry endpoint URL processing improved to handle http/https prefixes correctly
- Comprehensive end-to-end tests added to verify telemetry ConfigMap functionality
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
test/e2e/chainsaw/operator/single-tenancy/test-scenarios/telemetry-configmap/ | End-to-end test suite for telemetry ConfigMap functionality |
pkg/telemetry/providers/otlp/ | Fixed endpoint URL processing to strip http/https prefixes for OTLP clients |
cmd/thv-operator/controllers/mcpserver_runconfig_test.go | Added unit tests for telemetry configuration in runconfig generation |
cmd/thv-operator/controllers/mcpserver_runconfig.go | Added telemetry configuration processing for ConfigMap mode |
cmd/thv-operator/controllers/mcpserver_controller.go | Updated to skip individual telemetry CLI args when using ConfigMap mode |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
8f312a4
to
0daa717
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
0daa717
to
3e290d5
Compare
3e290d5
to
45a2a1c
Compare
No description provided.