Skip to content

Conversation

yrobla
Copy link
Contributor

@yrobla yrobla commented Sep 12, 2025

No description provided.

Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.75%. Comparing base (fc1aedf) to head (45a2a1c).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1858      +/-   ##
==========================================
+ Coverage   42.34%   44.75%   +2.40%     
==========================================
  Files         197      203       +6     
  Lines       25156    25920     +764     
==========================================
+ Hits        10653    11600     +947     
+ Misses      13667    13412     -255     
- Partials      836      908      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yrobla yrobla force-pushed the feature/telemetry-configmap-support branch from dcedfee to 5c726d0 Compare September 12, 2025 09:57
@coveralls
Copy link
Collaborator

coveralls commented Sep 12, 2025

Coverage Status

coverage: 41.247% (+0.09%) from 41.162%
when pulling 9a9142f on feature/telemetry-configmap-support
into e25f018 on main.

@yrobla yrobla force-pushed the feature/telemetry-configmap-support branch 4 times, most recently from 43f9eac to 8f312a4 Compare September 15, 2025 08:16
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive support for propagating telemetry configuration through ConfigMaps in the operator system. When ConfigMap mode is enabled, telemetry configurations from MCPServer specs are now properly serialized into runconfig.json files and consumed by the proxyrunner instead of being passed as individual CLI arguments.

  • Telemetry configuration is now included in ConfigMap runconfig.json when ConfigMap mode is enabled
  • OpenTelemetry endpoint URL processing improved to handle http/https prefixes correctly
  • Comprehensive end-to-end tests added to verify telemetry ConfigMap functionality

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/e2e/chainsaw/operator/single-tenancy/test-scenarios/telemetry-configmap/ End-to-end test suite for telemetry ConfigMap functionality
pkg/telemetry/providers/otlp/ Fixed endpoint URL processing to strip http/https prefixes for OTLP clients
cmd/thv-operator/controllers/mcpserver_runconfig_test.go Added unit tests for telemetry configuration in runconfig generation
cmd/thv-operator/controllers/mcpserver_runconfig.go Added telemetry configuration processing for ConfigMap mode
cmd/thv-operator/controllers/mcpserver_controller.go Updated to skip individual telemetry CLI args when using ConfigMap mode

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@yrobla yrobla force-pushed the feature/telemetry-configmap-support branch from 8f312a4 to 0daa717 Compare September 15, 2025 08:28
@yrobla yrobla requested a review from Copilot September 15, 2025 08:29
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@yrobla yrobla force-pushed the feature/telemetry-configmap-support branch from 0daa717 to 3e290d5 Compare September 15, 2025 08:33
@yrobla yrobla force-pushed the feature/telemetry-configmap-support branch from 3e290d5 to 45a2a1c Compare September 15, 2025 08:36
@yrobla yrobla merged commit cc4d03d into main Sep 15, 2025
18 checks passed
@yrobla yrobla deleted the feature/telemetry-configmap-support branch September 15, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants