Skip to content

fix(ui): Use correct platform component config variable name #15475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

sachaudh
Copy link
Contributor

Description

This PR just fixes an issue with a variable name. Turns out we are using platformComponentConfig rather than platformComponentsConfig 😢

Screenshots

Screenshot 2025-05-28 at 3 19 24 PM Screenshot 2025-05-28 at 3 21 27 PM Screenshot 2025-05-28 at 3 21 39 PM

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

@rhacs-bot
Copy link
Contributor

rhacs-bot commented May 28, 2025

Images are ready for the commit at 8ce9ca2.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-854-g8ce9ca26c8.

Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.25%. Comparing base (318baa6) to head (8ce9ca2).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #15475   +/-   ##
=======================================
  Coverage   49.25%   49.25%           
=======================================
  Files        2581     2581           
  Lines      189382   189382           
=======================================
+ Hits        93271    93273    +2     
+ Misses      88762    88760    -2     
  Partials     7349     7349           
Flag Coverage Δ
go-unit-tests 49.25% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from ROX-28171 to master May 29, 2025 14:54
@sachaudh sachaudh force-pushed the saif/fix-platform-component-config-endpoint branch from 0e4a1cb to 8ce9ca2 Compare May 29, 2025 14:56
@sachaudh sachaudh enabled auto-merge (squash) May 29, 2025 16:44
@sachaudh sachaudh disabled auto-merge May 29, 2025 19:38
@sachaudh
Copy link
Contributor Author

/retest-required

@sachaudh sachaudh merged commit 46de701 into master May 29, 2025
87 checks passed
@sachaudh sachaudh deleted the saif/fix-platform-component-config-endpoint branch May 29, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants