Skip to content

Don't library loo in tests #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

Don't library loo in tests #295

merged 1 commit into from
Jun 30, 2025

Conversation

VisruthSK
Copy link
Collaborator

Remove library(loo) in all tests as it is unnecessary.

Remove `library(loo`) in all tests as it is unnecessary.
@VisruthSK VisruthSK requested a review from jgabry June 28, 2025 18:24
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.78%. Comparing base (807e0ea) to head (787ef2c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #295   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files          31       31           
  Lines        2964     2964           
=======================================
  Hits         2750     2750           
  Misses        214      214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jgabry
Copy link
Member

jgabry commented Jun 29, 2025

Thanks @VisruthSK. Are all the changes other than removing library(loo) just formatting changes (that's what it looks like at first glance) or should I review all of those lines too?

@VisruthSK
Copy link
Collaborator Author

Yes the others are formatting changes--I accidentally formatted the test cases with air. I can undo that if preferred.

@jgabry
Copy link
Member

jgabry commented Jun 30, 2025

No worries, not a big deal for the tests. Let's just avoid doing it in the R directory until air is out of beta.

@jgabry jgabry merged commit 734c3be into master Jun 30, 2025
6 checks passed
@jgabry jgabry deleted the remove-library-loo branch June 30, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants