-
Notifications
You must be signed in to change notification settings - Fork 2k
Move pandas, datasets and optuna as optional deps #8274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Move pandas, datasets and optuna as optional deps #8274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left 2 minor comments, otherwise LGTM!
@@ -66,6 +68,9 @@ dev = [ | |||
] | |||
test_extras = [ | |||
"mcp; python_version >= '3.10'", | |||
"datasets>=2.14.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
open for discussion - do you think it's better to have these go to dev
or test_extras
? My first impression is they belong to dev
better, but not very sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think test_extras
should be a combination of all extra dependencies that are installed when running pytest
. To my understanding, dev
usually only contains packages that help development such as linter, test libraries.
Since DSPy 3.0, DSPy does not include dependencies for optimizers such as
pandas
, ordatasets
as its core dependencies. This is for making DSPy production-ready, allowing users to use DSPy programs without installing large dependencies during inference time. This PR reduces the file volume size of DSPy dependencies from 284 MB to 115MB.Users should run
pip install dspy[optimize]
to install those packages when running DSPy optimizers.