Port to orjson from ujson
#8584
Open
+30
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtmckee
reviewed
Aug 4, 2025
| @@ -318,7 +318,7 @@ def _save_data_to_local_file(train_data: list[dict[str, Any]], data_format: Trai | |||
| elif data_format == TrainDataFormat.COMPLETION: | |||
| _validate_completion_data(item) | |||
|
|
|||
| f.write(ujson.dumps(item) + "\n") | |||
| f.write(orjson.dumps(item).decode() + "\n") | |||
There was a problem hiding this comment.
I recommend changing the open(file_path, "w"), above, to "wb" mode to eliminate the decodes happening here.
The end result will be:
Suggested change
| f.write(orjson.dumps(item).decode() + "\n") | |
| f.write(orjson.dumps(item) + b"\n") |
Comment on lines
61
to
+63
| with open(file_path, "w") as f: | ||
| for item in data: | ||
| f.write(ujson.dumps(item) + "\n") | ||
| f.write(orjson.dumps(item).decode() + "\n") |
There was a problem hiding this comment.
As above, I recommend eliminating the calls to .decode():
with open(file_path, "wb") as f:
for item in data:
f.write(orjson.dumps(item) + b"\n")This suggestion applies to the other change in this file.
Comment on lines
251
to
+252
| with open(path, encoding="utf-8") as f: | ||
| state = ujson.loads(f.read()) | ||
| state = orjson.loads(f.read().encode('utf-8')) |
There was a problem hiding this comment.
Last place I'll leave feedback, but in general the suggestion is "don't decode content only to re-encode it immediately:
with open(path, "rb") as f:
state = orjson.loads(f.read())Also, these are pathlib objects so this is more ideal:
state = orjson.loads(path.read_bytes())
|
Thanks so much @aadya940 and thanks @kurtmckee for the comments! @aadya940 Mind addressing the failures (ruff mostly? or maybe some tests?) and checking out the comments (I didn't dive into them) |
0xEval
pushed a commit
to 0xEval/dspy-orjson-mig
that referenced
this pull request
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified in #8540 ,
ujsonis in maintanance mode.