Choice #3
Open
Choice #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikh3x4
requested review from
Nate711,
rao-ashish,
ncsariowan and
nivedithasi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically made it default to only sending message to same device. It no longer treats 10.0.0.X as some special magic network.
There is a Scope configuratoin mechanism that can be used to send messages to other devices (I think Scope.Multicast() should work, the older behabiour is presernved using Scope.Broadcast("10.0.0.X"). Its explained in the readme :D
Note I still haven't tested this on all the combinations so I'll wait to merge it. Just notifying you who use it that defualts will be differnt. I'll also push it to pip so we'll be able to do
pip install UDPComms