fix: missing snip-12 enum type dependency #1289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penovicp
reviewed
Jan 2, 2025
|
Sure thing. Sorry I should have added the tests to start with. I will generate the tests using my impl in |
penovicp
force-pushed
the
dev/snip_12_enum_dep
branch
from
ce7dbe0 to
e57eaf3
Compare
penovicp
added a commit
that referenced
this pull request
Mar 20, 2025
* fix: missing snip-12 enum type dependency * test: add nested enum tests --------- Co-authored-by: Petar Penovic <[email protected]>
penovicp
added a commit
that referenced
this pull request
Mar 20, 2025
* fix: missing snip-12 enum type dependency * test: add nested enum tests --------- Co-authored-by: Petar Penovic <[email protected]>
penovicp
added a commit
that referenced
this pull request
Mar 20, 2025
* fix: missing snip-12 enum type dependency * test: add nested enum tests --------- Co-authored-by: Petar Penovic <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Mar 20, 2025
## [6.24.1](v6.24.0...v6.24.1) (2025-03-20) ### Bug Fixes * repair snip-12 enum type nested dependency ([#1289](#1289)) ([1cd4219](1cd4219))
github-actions bot
pushed a commit
that referenced
this pull request
Mar 28, 2025
# [7.0.0-beta.4](v7.0.0-beta.3...v7.0.0-beta.4) (2025-03-28) ### Bug Fixes * repair snip-12 enum type nested dependency ([#1289](#1289)) ([1cd4219](1cd4219)) ### Features * drop fetch-cookie dependency ([9a57daf](9a57daf)) * drop isomorphic-fetch dependency ([9da0083](9da0083)) * prune deprecated functionalities ([cbd18f5](cbd18f5)) ### BREAKING CHANGES * Removed multiple functionalities that have been marked as deprecated
PhilippeR26
added a commit
to PhilippeR26/starknet.js
that referenced
this pull request
May 5, 2025
docs: update guide build: ledger app v2.3.0 chore: upgrade name to 2.3.1 and polish doc docs: update guide chore: upgrade name to 2.3.1 and polish doc feat: prune deprecated functionalities BREAKING CHANGE: Removed multiple functionalities that have been marked as deprecated chore(release): 7.0.0-beta.4 [skip ci] * repair snip-12 enum type nested dependency ([starknet-io#1289](starknet-io#1289)) ([1cd4219](starknet-io@1cd4219)) * drop fetch-cookie dependency ([9a57daf](starknet-io@9a57daf)) * drop isomorphic-fetch dependency ([9da0083](starknet-io@9da0083)) * prune deprecated functionalities ([cbd18f5](starknet-io@cbd18f5)) * Removed multiple functionalities that have been marked as deprecated chore(release): 7.0.0 [skip ci] * Implement RPC 0.8 and V3 transactions ([starknet-io#1328](starknet-io#1328)) ([316ae27](starknet-io@316ae27)) * contract withOptions Fix/1252 ([starknet-io#1255](starknet-io#1255)) ([b59952e](starknet-io@b59952e)) * update ws impl, add TEST_WS_URL, update token constants ([411eeec](starknet-io@411eeec)) * drop fetch-cookie dependency ([9a57daf](starknet-io@9a57daf)) * drop isomorphic-fetch dependency ([9da0083](starknet-io@9da0083)) * prune deprecated functionalities ([cbd18f5](starknet-io@cbd18f5)) * the WebSockets ([starknet-io#1251](starknet-io#1251)) ([fabca27](starknet-io@fabca27)), closes [starknet-io#1272](starknet-io#1272) * Update Beta to latest Develop ([starknet-io#1312](starknet-io#1312)) ([2958051](starknet-io@2958051)), closes [starknet-io#949](starknet-io#949) [starknet-io#970](starknet-io#970) * v7 fee, new methods, tests ([starknet-io#1337](starknet-io#1337)) ([00743de](starknet-io@00743de)) * Removed multiple functionalities that have been marked as deprecated * Library defaults to RPC 0.8 with the corresponding API changes, dropped RPC 0.6 support fix: preserve value for numeric arguments within address padding utility chore(release): 7.0.1 [skip ci] * preserve value for numeric arguments within address padding utility ([abc7958](starknet-io@abc7958)) docs: generate documentation version docs: expand v7 migration guide (starknet-io#1368) --------- Co-authored-by: Petar Penovic <[email protected]> fix: make the provider create method generic to enable it when mixins are applied (starknet-io#1370) fix: ensure enum replacement objects are reachable for type resolution (starknet-io#1375) docs: update guides for v7 (starknet-io#1376) --------- Co-authored-by: Petar Penovic <[email protected]> feat: update to rpc 0.8.1 chore(release): 7.1.0 [skip ci] * ensure enum replacement objects are reachable for type resolution ([starknet-io#1375](starknet-io#1375)) ([eb8b10d](starknet-io@eb8b10d)) * make the provider create method generic to enable it when mixins are applied ([starknet-io#1370](starknet-io#1370)) ([1f48dc6](starknet-io@1f48dc6)) * update to rpc 0.8.1 ([83e17b8](starknet-io@83e17b8)) style: remove comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
Resolves #1287.
Checklist: