-
Notifications
You must be signed in to change notification settings - Fork 818
0.11.0 Sequencer API #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
0.11.0 Sequencer API #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for starknetjs canceled.
|
…sh api response, fix OPENRPC
ivpavici
reviewed
Mar 28, 2023
Co-authored-by: Ivan Pavičić <[email protected]>
Co-authored-by: Ivan Pavičić <[email protected]>
…t.js into feat/0.11.0/api-sequencer
ivpavici
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ship this as prerelease and fix later if issues arise!
🎉 This PR is included in version 5.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
Resolve #516
only essential #432 for RPC, Sequencer, Provider. Splited this part into another PR that will deal with response types.
Expose CallData for CallData.compile usage
Fix #557
Fix #547
Fix #537
The basic stuff was done. didn't do cleanup nor new endpoints tests.
get_compiled_class_by_class_hash
get_class_by_hash
computeSieraContractClassHash
RPC version (if applicable)
Hotfixed current provider - rpc interface until the new RPC release
Usage related changes
LegacyContractClass
equal to oldContractClass
ContractClass
equal toLegacyContractClass | SieraContractClass
Development related changes
estimate fee does not work with 'feeTransactionVersion_2' (2n ** 128n + 2n) but only '2n'
How to test declare v2 if can't re-declare the same contract on testnet?
Checklist: