Skip to content

Conversation

tabaktoni
Copy link
Member

@tabaktoni tabaktoni commented Feb 23, 2023

Motivation and Resolution

Resolve #516
only essential #432 for RPC, Sequencer, Provider. Splited this part into another PR that will deal with response types.
Expose CallData for CallData.compile usage
Fix #557
Fix #547
Fix #537

The basic stuff was done. didn't do cleanup nor new endpoints tests.

  • get_compiled_class_by_class_hash
  • get_class_by_hash
  • implement computeSieraContractClassHash
  • get_full_contract
  • get_state_update
  • get_block
  • get_transaciton
  • estimate_fee
  • update docs for hash Cairo1

RPC version (if applicable)

Hotfixed current provider - rpc interface until the new RPC release

Usage related changes

LegacyContractClass equal to old ContractClass
ContractClass equal to LegacyContractClass | SieraContractClass

Development related changes

estimate fee does not work with 'feeTransactionVersion_2' (2n ** 128n + 2n) but only '2n'
How to test declare v2 if can't re-declare the same contract on testnet?

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes
  • Updated the docs (www)
  • Updated the tests
  • All tests are passing

@netlify
Copy link

netlify bot commented Feb 23, 2023

Deploy Preview for starknetjs canceled.

Name Link
🔨 Latest commit 6e33a79
🔍 Latest deploy log https://app.netlify.com/sites/starknetjs/deploys/642445092080e800083a5e3b

@tabaktoni tabaktoni changed the title (wip) 0.11.0 Sequencer API 0.11.0 Sequencer API Mar 28, 2023
@tabaktoni tabaktoni requested a review from ivpavici March 29, 2023 12:10
Copy link
Collaborator

@ivpavici ivpavici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship this as prerelease and fix later if issues arise!

@tabaktoni tabaktoni merged commit 6bd1ac5 into develop Mar 29, 2023
@github-actions
Copy link
Contributor

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

expose CallData migration 4.22 -> 5.1.0 - contract.call and provider.waitForTransaction (0.11.0) Implement Sequencer and RPC api changes

3 participants