adopt columns into the BN, except column syncing
#6945
+1,335
−357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tersec
reviewed
Aug 8, 2025
| return true | ||
|
|
||
| else: | ||
| return false |
tersec
reviewed
Aug 8, 2025
| @@ -298,12 +298,8 @@ func getMaxBlobsPerBlock(cfg: RuntimeConfig, slot: Slot): uint64 = | |||
| if slot >= cfg.FULU_FORK_EPOCH.start_slot: | |||
| let | |||
| epoch: Epoch = Epoch(uint64(slot) div SLOTS_PER_EPOCH) | |||
There was a problem hiding this comment.
this is just slot.epoch, and doesn't need the extra : Epoch (lets almost never need to be told the type they have).
tersec
reviewed
Aug 8, 2025
tersec
reviewed
Aug 9, 2025
| @@ -21,7 +21,7 @@ const | |||
| ## Arbitrary | |||
| MaxOrphans = SLOTS_PER_EPOCH * 3 | |||
| ## Enough for finalization in an alternative fork | |||
| MaxSidecarless = SLOTS_PER_EPOCH * 128 | |||
| MaxSidecarless = SLOTS_PER_EPOCH | |||
There was a problem hiding this comment.
In general, should verify this reduction is safe.
tersec
reviewed
Aug 11, 2025
| vcus.dag.cfg.MIN_EPOCHS_FOR_BLOB_SIDECARS_REQUESTS - 1) | ||
| var numberOfColumnEpochs = vcus.dag.cfg.MIN_EPOCHS_FOR_BLOB_SIDECARS_REQUESTS.int - 1 | ||
| if slot.is_epoch() and dataColumnRefillEpoch >= vcus.dag.cfg.FULU_FORK_EPOCH: | ||
| var blocks = newSeq[BlockId](vcus.dag.cfg.MIN_EPOCHS_FOR_BLOB_SIDECARS_REQUESTS.int) |
There was a problem hiding this comment.
This seems like a high upper bound to always allocate. Apparently it only uses from 0 to numberOfColumnEpochs?
Also toOpenArray is inclusive on both its bounds but for i in startIndex..<numberOfColumnEpochs.int is exclusive on the upper bound.
tersec
reviewed
Aug 11, 2025
| # behind is currently undergoing excess column refilling. | ||
| vcus.dag.erSlot = slot | ||
| let dataColumnRefillEpoch = (slot.epoch - | ||
| vcus.dag.cfg.MIN_EPOCHS_FOR_BLOB_SIDECARS_REQUESTS - 1) |
There was a problem hiding this comment.
vcus should probably line up with slot not ( if one is going to do this approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from the
columnsbranch. This branch essentially attempts to add column support to the nimbus-eth2 CL post FULU_FORK_EPOCH. However it does NOT contain column syncing baked into existingSyncManagerNote that all column related mechanics, are gated to and after the Fulu fork, would be helpful to have more eyes on the gating.