Skip to content

Add peerDAS gossip metrics #7066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

KatyaRyazantseva
Copy link

Add peerDAS gossip metrics to align with the beacon metrics specs:

  • beacon_data_column_sidecar_processing_requests_total
  • beacon_data_column_sidecar_processing_successes_total
  • beacon_data_column_sidecar_gossip_verification_seconds

Copy link

github-actions bot commented Apr 11, 2025

Unit Test Results

       15 files  ±0    2 630 suites  ±0   1h 17m 49s ⏱️ + 5m 50s
  6 339 tests ±0    5 837 ✔️ ±0  502 💤 ±0  0 ±0 
44 116 runs  ±0  43 438 ✔️ ±0  678 💤 ±0  0 ±0 

Results for commit ece0099. ± Comparison against base commit dfc5970.

♻️ This comment has been updated with latest results.

@@ -43,6 +43,16 @@ declareCounter beacon_sync_messages_dropped_queue_full,
declareCounter beacon_contributions_dropped_queue_full,
"Number of sync committee contributions dropped because queue is full"

declareCounter beacon_data_column_sidecar_processing_requests_total,
"Number of data column sidecars submitted for processing"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid indentation

@agnxsh
Copy link
Contributor

agnxsh commented Apr 25, 2025

please run locally with make -jX nimbus_beacon_node in order to check if it can pass CI first

@KatyaRyazantseva KatyaRyazantseva marked this pull request as ready for review April 25, 2025 10:44
@agnxsh agnxsh merged commit 6de64f4 into status-im:column-metrics Apr 26, 2025
9 checks passed
agnxsh pushed a commit that referenced this pull request Apr 26, 2025
* Add peerDAS gossip metrics

* Add formatting
agnxsh pushed a commit that referenced this pull request May 12, 2025
* Add peerDAS gossip metrics

* Add formatting
agnxsh added a commit that referenced this pull request Jun 3, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Add peerDAS gossip metrics (#7066)

* Add peerDAS gossip metrics

* Add formatting

* Add peerDAS kzg batch verification metric into gossip_validation

* Fix time

---------

Co-authored-by: Agnish Ghosh <[email protected]>
agnxsh added a commit that referenced this pull request Jun 3, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Add peerDAS gossip metrics (#7066)

* Add peerDAS gossip metrics

* Add formatting

* Add peerDAS inclusion proof metric into gossip_validation

* Fix inclusion proof metric time

* fix kzg verification metric

---------

Co-authored-by: Agnish Ghosh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants