Skip to content

Add PeerDAS engine_getBlobsV2 metrics #7207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged

Add PeerDAS engine_getBlobsV2 metrics #7207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions beacon_chain/gossip_processing/eth2_processor.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,16 @@ declareHistogram beacon_data_column_sidecar_computation_seconds,
"Time taken to compute data column sidecar, including cells and inclusion proof",
buckets = [0.005, 0.01, 0.025, 0.05, 0.075, 0.1, 0.25, 0.5, 0.75, 1.0, 2.5, 5.0, 7.5, 10.0, Inf]

declareCounter beacon_engine_getBlobsV2_requests_total,
"Total number of engine_getBlobsV2 requests sent"

declareCounter beacon_engine_getBlobsV2_responses_total,
"Total number of engine_getBlobsV2 successful responses received"

declareHistogram beacon_engine_getBlobsV2_runtime_seconds,
"Full runtime of engine_getBlobsV2 requests",
buckets = [0.001, 0.005, 0.01, 0.025, 0.05, 0.75, 0.1, 0.5, 1, 1.5, 2, 5, 10]

type
DoppelgangerProtection = object
broadcastStartEpoch*: Epoch ##\
Expand Down Expand Up @@ -366,12 +376,17 @@ proc validateDataColumnSidecarFromEL*(
let columnless = o.unsafeGet()
withBlck(columnless):
when consensusFork >= ConsensusFork.Fulu:
beacon_engine_getBlobsV2_requests_total.inc()
let
start_time = Moment.now()
let blobsFromElOpt =
await elManager.sendGetBlobsV2(forkyBlck)
blobsFromElOpt =
await elManager.sendGetBlobsV2(forkyBlck)
getBlobsV2_end_time = Moment.now()
getBlobsV2_dur = getBlobsV2_end_time - start_time
beacon_engine_getBlobsV2_runtime_seconds.observe(getBlobsV2_dur.toFloatSeconds())
if blobsFromElOpt.isSome():
let blobsEl = blobsFromElOpt.get()
beacon_engine_getBlobsV2_responses_total.inc()

# check lengths of array[BlobAndProofV2 with blobs
# kzg commitments of the signed block
Expand Down
Loading