Skip to content

bump nim-eth to 92a02b672f60e6b5e5ea570d684904c289b495fa #7209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 28, 2025
Merged

Conversation

chirag-parmar
Copy link

No description provided.

Copy link

github-actions bot commented Jun 4, 2025

Unit Test Results

       15 files    2 650 suites   1h 18m 6s ⏱️
  6 546 tests   6 022 ✔️ 524 💤 0
45 406 runs  44 658 ✔️ 748 💤 0

Results for commit afbadd1.

♻️ This comment has been updated with latest results.

@chirag-parmar chirag-parmar marked this pull request as ready for review June 8, 2025 13:54
@chirag-parmar chirag-parmar marked this pull request as draft June 26, 2025 08:21
@chirag-parmar chirag-parmar marked this pull request as ready for review June 26, 2025 10:12
@etan-status
Copy link
Contributor

To support nimble based testing in nim-web3, should tag this as a release in nim-eth; otherwise, things can get slightly inconsistent.

libnimbus_lc.nim changes lgtm. Do you want me to look into specific nim-eth changes as well?

@chirag-parmar
Copy link
Author

To support nimble based testing in nim-web3, should tag this as a release in nim-eth; otherwise, things can get slightly inconsistent.

libnimbus_lc.nim changes lgtm. Do you want me to look into specific nim-eth changes as well?

@etan-status no those changes have already been approved. I don't think we tag releases in nim-eth for everytime we bump the commit hash in eth1 and eth2

@chirag-parmar chirag-parmar changed the title bump nim-eth bump nim-eth to 92a02b672f60e6b5e5ea570d684904c289b495fa Jun 26, 2025
@chirag-parmar
Copy link
Author

@tersec shall i merge this?

@tersec tersec merged commit 3303754 into unstable Jun 28, 2025
19 of 20 checks passed
@tersec tersec deleted the bump-nim-eth branch June 28, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants