Add beacon api postStateValidatorIdentities #7223
Conversation
| @@ -223,6 +223,11 @@ type | |||
| status*: string | |||
| validator*: Validator | |||
|
|
|||
| RestValidatorIdentity* = object | |||
| index*: ValidatorIndex | |||
| pubkeyData*{.serializedFieldName: "pubkey".}: HashedValidatorPubKey | |||
There was a problem hiding this comment.
why can't this field just be called pubkey?
There was a problem hiding this comment.
Yeah both work for me. I think it mainly helps the naming consistency as other types using HashedValidatorPubKey are pubkeyData.
There was a problem hiding this comment.
There is no reason to call it pubkeyData, to keep naming consistency rename it please to pubkey. Even if some types internally using pubkeyData all the REST types using pubkey.
There was a problem hiding this comment.
Also i have not seen HashedValidatorPubKey serialization/deserialization procedure, so it will not working because its impossible to automatically decode this type, so i think proper type for this object would be ValidatorPubKey.
There was a problem hiding this comment.
What does it mean? Serialization is working fine for Validator in the response of other APIs.
There was a problem hiding this comment.
It means that it could provide whatever json-serialization will prefer, which probably could be totally incompatible with what specification means.
There was a problem hiding this comment.
There is no reason to call it
pubkeyData, to keep naming consistency rename it please topubkey. Even if some types internally usingpubkeyDataall the REST types usingpubkey.
|
This change require implementation of additional tests in |
|
postStateValidatorIdentitiesin Beacon-APIs #7151