-
-
Notifications
You must be signed in to change notification settings - Fork 837
feat: add reverse
method to array/fixed-endian-factory
#3293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: add reverse
method to array/fixed-endian-factory
#3293
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/fixed-endian-factory/test/test.reverse.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/fixed-endian-factory/test/test.reverse.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Vinit Pandit <[email protected]> Signed-off-by: Ahmed_Kashkoush <[email protected]>
Co-authored-by: Vinit Pandit <[email protected]> Signed-off-by: Ahmed_Kashkoush <[email protected]>
Co-authored-by: Vinit Pandit <[email protected]> Signed-off-by: Ahmed_Kashkoush <[email protected]>
Co-authored-by: Vinit Pandit <[email protected]> Signed-off-by: Ahmed_Kashkoush <[email protected]>
…reverse.js Co-authored-by: Vinit Pandit <[email protected]> Signed-off-by: Ahmed_Kashkoush <[email protected]>
…reverse.js Co-authored-by: Vinit Pandit <[email protected]> Signed-off-by: Ahmed_Kashkoush <[email protected]>
@MeastroZI thanks for the review, may I ask for a formatting command? because |
I don’t think there’s a specific formatting command available. However, lint errors will be shown whenever you commit and push your changes ( if development setup is correct) . Beyond that, you’ll need to manually ensure your code adheres to the required coding style. Cheers! |
thanks. and is there any change I should do to this PR now? |
Looks good from my side, let the maintainers have a look on this ! |
@kgryte resolved conflicts, and update method place so main, and readme are ordered alphatically. |
@kgryte @Planeshifter Should I update anything? |
Resolves #3153
Description
This pull request:
Related Issues
This pull request:
reverse
method toarray/fixed-endian-factory
#3153Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers