Skip to content

feat: add reverse method to array/fixed-endian-factory #3293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

ahmad-kashkoush
Copy link
Contributor

Resolves #3153

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 28, 2024

Coverage Report

Package Statements Branches Functions Lines
array/fixed-endian-factory $\color{red}1209/1459$
$\color{green}+82.86\%$
$\color{red}161/173$
$\color{green}+93.06\%$
$\color{red}25/34$
$\color{green}+73.53\%$
$\color{red}1209/1459$
$\color{green}+82.86\%$

The above coverage report was generated for the changes in this PR.

@ahmad-kashkoush
Copy link
Contributor Author

@MeastroZI thanks for the review, may I ask for a formatting command? because make lint command only checks for linting errors but doesn't fix them

@Vinit-Pandit
Copy link
Contributor

@MeastroZI thanks for the review, may I ask for a formatting command? because make lint command only checks for linting errors but doesn't fix them

I don’t think there’s a specific formatting command available. However, lint errors will be shown whenever you commit and push your changes ( if development setup is correct) . Beyond that, you’ll need to manually ensure your code adheres to the required coding style.

Cheers!

@ahmad-kashkoush
Copy link
Contributor Author

@MeastroZI thanks for the review, may I ask for a formatting command? because make lint command only checks for linting errors but doesn't fix them

I don’t think there’s a specific formatting command available. However, lint errors will be shown whenever you commit and push your changes ( if development setup is correct) . Beyond that, you’ll need to manually ensure your code adheres to the required coding style.

Cheers!

thanks. and is there any change I should do to this PR now?

@Vinit-Pandit
Copy link
Contributor

thanks. and is there any change I should do to this PR now?

Looks good from my side, let the maintainers have a look on this !

@ahmad-kashkoush
Copy link
Contributor Author

@kgryte resolved conflicts, and update method place so main, and readme are ordered alphatically.

@ahmad-kashkoush
Copy link
Contributor Author

@kgryte @Planeshifter Should I update anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add reverse method to array/fixed-endian-factory
3 participants