Skip to content

chore: fix JavaScript lint errors #5775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

chore: fix JavaScript lint errors #5775

merged 1 commit into from
Mar 4, 2025

Conversation

jalajk3004
Copy link
Contributor

@jalajk3004 jalajk3004 commented Mar 4, 2025 •
edited
Loading

Resolves #5771.

Description

What is the purpose of this pull request?

This pull request:

  • {{TODO: add description describing what this pull request does}}

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@jalajk3004
added a empty line
448e12b 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 4, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
buffer/from-arraybuffer $\color{green}334/334$
$\color{green}+100.00\%$ 		$\color{red}47/48$
$\color{green}+97.92\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}334/334$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@jalajk3004 jalajk3004 changed the title Fix JavaScript lint errors Fixes JavaScript lint errors Mar 4, 2025
@jalajk3004 jalajk3004 changed the title Fixes JavaScript lint errors chore: fix JavaScript lint errors Mar 4, 2025
gururaj1512
gururaj1512 approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@gururaj1512 gururaj1512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 4, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 4, 2025
@Planeshifter Planeshifter mentioned this pull request Mar 4, 2025
Closed
1 task
@stdlib-bot
Copy link
Contributor

PR Commit Message

chore: fix JavaScript lint errors

PR-URL: https://github.com/stdlib-js/stdlib/pull/5775
Closes: https://github.com/stdlib-js/stdlib/issues/5771

Co-authored-by: jalajk3004 <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Gururaj Gurram <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 77c2bfd into stdlib-js:develop Mar 4, 2025
71 of 74 checks passed
NirvedMishra pushed a commit to NirvedMishra/stdlib that referenced this pull request Mar 4, 2025
@jalajk3004 @NirvedMishra
chore: fix JavaScript lint errors
beeb983 
PR-URL: stdlib-js#5775
Closes: stdlib-js#5771

Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Gururaj Gurram <[email protected]>

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
NirvedMishra pushed a commit to NirvedMishra/stdlib that referenced this pull request Mar 4, 2025
@jalajk3004 @NirvedMishra
chore: fix JavaScript lint errors
867e91c 
PR-URL: stdlib-js#5775
Closes: stdlib-js#5771

Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Gururaj Gurram <[email protected]>

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
---
NirvedMishra pushed a commit to NirvedMishra/stdlib that referenced this pull request Mar 4, 2025
@jalajk3004 @NirvedMishra
chore: fix JavaScript lint errors
d4788ea 
PR-URL: stdlib-js#5775
Closes: stdlib-js#5771

Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Gururaj Gurram <[email protected]>

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@jalajk3004 jalajk3004 mentioned this pull request Mar 29, 2025
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@gururaj1512 gururaj1512 gururaj1512 approved these changes

Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors
4 participants
@jalajk3004 @stdlib-bot @Planeshifter @gururaj1512