feat: add blas/base/wasm/scnrm2
#6791
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
stdlib-bot
added
BLAS
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
/stdlbi update-copyright-years |
Signed-off-by: Shabareesh Shetty <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
|
/stdlib update-copyright-years |
stdlib-bot
added
the
bot: In Progress
stdlib-bot
removed
the
bot: In Progress
kgryte
added
Feature
kgryte
reviewed
Jun 20, 2025
Signed-off-by: Athan <[email protected]>
kgryte
reviewed
Jun 20, 2025
lib/node_modules/@stdlib/blas/base/wasm/scnrm2/benchmark/benchmark.module.main.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Jun 20, 2025
lib/node_modules/@stdlib/blas/base/wasm/scnrm2/benchmark/benchmark.module.ndarray.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
kgryte
reviewed
Jun 20, 2025
lib/node_modules/@stdlib/blas/base/wasm/scnrm2/test/test.main.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
kgryte
reviewed
Jun 20, 2025
lib/node_modules/@stdlib/blas/base/wasm/scnrm2/test/test.module.ndarray.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
kgryte
reviewed
Jun 20, 2025
| // FUNCTIONS // | ||
|
|
||
| /** | ||
| * Tests for element-wise approximate equality. |
There was a problem hiding this comment.
@ShabiShett07 Why are we testing for element-wise equality? The value returns a scalar, not an array. This same comment applies to all the tests. I am pretty sure these tests are all broken due to incorrect arguments. E.g., expected.length is undefined, as a number has no length property; hence, the loop never runs.
kgryte
reviewed
Jun 20, 2025
| * @param {Collection} expected - expected values | ||
| * @param {number} rtol - relative tolerance | ||
| */ | ||
| function isApprox( t, actual, expected, rtol ) { |
kgryte
reviewed
Jun 20, 2025
| * @param {Collection} expected - expected values | ||
| * @param {number} rtol - relative tolerance | ||
| */ | ||
| function isApprox( t, actual, expected, rtol ) { |
kgryte
reviewed
Jun 20, 2025
| * @param {Collection} expected - expected values | ||
| * @param {number} rtol - relative tolerance | ||
| */ | ||
| function isApprox( t, actual, expected, rtol ) { |
kgryte
requested changes
Jun 20, 2025
kgryte
added
Needs Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
none
Description
This pull request:
blas/base/wasm/scnrm2Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers