Change http-proxy & types into dependencies #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe these dependencies needs to lie in the
dependencies
array so that they're accessible to consumers of your library.Installing version 1.0.8 yields Typescript errors whenever I try to add any
NextHttpProxyMiddlewareOptions
originating from@types/http-proxy
, e.g.:Error:
The same version also yields runtime errors, since
http-proxy
isn't installed:Error: Cannot find module 'http-proxy'
.