Fix event listener on "proxyReq" #77
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stegano
reviewed
Oct 26, 2022
| if (hasRequestBodyMethods.indexOf(req.method as string) >= 0 && typeof req.body === "string") { | ||
| proxyReq.write(req.body); | ||
| proxyReq.end(); | ||
| .once("proxyReq", ((proxyReq: http.ClientRequest, req: http.IncomingMessage): void => { |
There was a problem hiding this comment.
Hi @casheeeewnuts
Thanks for your PR
Serializing req.body was used to solve the problem(#3) of sending HTTP Request Body, but it seems that it is no longer needed(#33). 😀
Thanks :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code has a problem that calling proxyReq.end() method don't wait proxyReq.write(req.body).
To fix, proxyReq.end() must be called in callback that be passed second argument with proxyReq.write().
Another solution is piping the original request to proxy with req.pipe(). By use it, dont need to use JSON.stringify() to serialize request body.
So, performance improvement expected.
And more type-safe.