Skip to content

fix: make jest and ts-jest devDependencies #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

gthb
Copy link
Contributor

@gthb gthb commented Jan 7, 2021

Testing libraries should not be runtime dependencies.

@stegano stegano merged commit 841994d into stegano:master Jan 8, 2021
@stegano
Copy link
Owner

stegano commented Jan 8, 2021

Hi, @gthb

Thanks for your PR! 😀

I think all dependencies can move to devDependencies. 🤔

@stegano stegano self-requested a review January 8, 2021 02:50
@stegano stegano added dependencies Pull requests that update a dependency file good first issue Good for newcomers labels Jan 8, 2021
@gthb
Copy link
Contributor Author

gthb commented Jan 8, 2021

I think all dependencies can move to devDependencies. 🤔

Oh! Sure, I guess 😊 — I only looked at the ones that were leading to version constraint conflicts in our runtime dependencies.

@gthb gthb deleted the fix-dev-dependencies branch January 8, 2021 09:16
@stegano
Copy link
Owner

stegano commented Jan 27, 2021

@all-contributors please add @gthb for code and ideas

Repository owner deleted a comment from allcontributors bot Jan 27, 2021
@allcontributors
Copy link
Contributor

@stegano

I've put up a pull request to add @gthb! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants