Improvements to the GitHub Action tests #747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…container does not startup
leighmcculloch
changed the base branch from
main
to
update-action-test-workflow
leighmcculloch
changed the base branch from
update-action-test-workflow
to
main
leighmcculloch
changed the title
sagpatil
approved these changes
Aug 28, 2025
sagpatil
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix which image the action test pr build runs on.
Move the action-test workflow to run after each individual image build.
Replace manual Docker setup using Homebrew with official Docker GitHub Action.
Why
The action-test workflow was waiting for all image builds to finish, but it can start running on each image separately. Also the tag prefix that was being used by the action build didn't include the tag pr prefix because the tag pr prefix was being set lower down and the tag prefix known higher up didn't contain it.
The homebrew install and setup of lima is really slow, leading to the action taking 12-12 minutes on a macos-13 instance. That's too long for realistic usage inside CI. Docker have an action that does a setup of lima and docker, and maybe it is faster. Giving it a go in this change.