Skip to content

Synchronize PlatformIO build script #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2021
Merged

Conversation

valeros
Copy link
Contributor

@valeros valeros commented May 24, 2021

This PR brings the PlatformIO build script up-to-date according to the latest changes in the Arduino Core v2.0 (platformio/platform-ststm32#521).

@fpistm fpistm added the fix 🩹 Bug fix label May 24, 2021
@fpistm fpistm added this to the 2.x.x milestone May 24, 2021
@fpistm
Copy link
Member

fpistm commented May 24, 2021

@valeros
Vould you rebase on top.
PIO build was disabled. I reenable it.

@fpistm
Copy link
Member

fpistm commented May 24, 2021

@valeros I've made the rebase of your branch 😉

@fpistm fpistm self-requested a review May 24, 2021 13:54
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GHA PIO build is now up and running without any workaround.
Thank you @valeros

@fpistm fpistm merged commit a728373 into stm32duino:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants