Serial update #264
Merged
Serial update #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review Serial menu, 3 options:
- Enabled with generic Serial: default, define HAL_UART_MODULE_ENABLED
and instanciate Serial using SERIAL_UART_INSTANCE and PIN_SERIAL_RX/PIN_SERIAL_Tx
- Enabled without generic Serial: define HAL_UART_MODULE_ENABLED
- Disabled (No Serial): HAL_UART_MODULE_ENABLED not defined
Allow to build without HAL_UART_MODULE_ENABLED (save memory)
Now, HAL_UART_MODULE_ENABLED should not be defined in stm32yyxx_hal_conf.h
Signed-off-by: Frederic Pillon <[email protected]>
Signed-off-by: Frederic Pillon <[email protected]>
Backup domain is handled by HAL_RCCEx_PeriphCLKConfig() when changing RTC clock source. If one other peripheral uses LSE and RTC do not use it, force reset of the backup domain will break this peripheral. Signed-off-by: Frederic.Pillon <[email protected]>
Handle properly clock activation. Signed-off-by: Frederic Pillon <[email protected]>
Avoid duplicated common settings Use GPIO_SPEED_FREQ_VERY_HIGH if exists Init OneBitSampling fields if exists Signed-off-by: Frederic Pillon <[email protected]>
HAL_UART_GetState() return a combined value. So mask needs to be applied before compare the value. Signed-off-by: Frederic Pillon <[email protected]>
Signed-off-by: Frederic Pillon <[email protected]>
__HAL_GET_PENDING_IT() read IT line status in SYSCFG register which required to be clocked. This set of registers is implemented only on STM32F09x to collect all pending interrupt sources associated with each interrupt line into a single register. This allows users to check by single read which peripheral requires service in case more than one source is associated to the interrupt line. Fix stm32duino#260 Signed-off-by: Frederic Pillon <[email protected]>
benwaffle
pushed a commit
to benwaffle/Arduino_Core_STM32
that referenced
this pull request
Apr 10, 2019
Serial update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several update around Serial feature;
Review Serial menu, 3 options:
- Enabled with generic Serial: default, define HAL_UART_MODULE_ENABLED
and instantiate Serial using SERIAL_UART_INSTANCE and PIN_SERIAL_RX/PIN_SERIAL_Tx
- Enabled without generic Serial: define HAL_UART_MODULE_ENABLED
- Disabled (No Serial): HAL_UART_MODULE_ENABLED not defined
Allow to build without HAL_UART_MODULE_ENABLED (save memory)
Now, HAL_UART_MODULE_ENABLED should not be defined in stm32yyxx_hal_conf.h
Add LPUART1 management
Fix serial_[rx|tx]_active functions
Clean up comments
Fix UART7 causes Nucleo F091RC to lock up #260