[I2C] Fix error reporting on I2C timeout #872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this timeout is triggered, I2C_OK was returned. This happens because in the loop above, it checks for `(delta < I2C_TIMEOUT_TICK)`, so it breaks out of the loop as soon as `delta == I2C_TIMEOUT_TICK`. Then, the if below checks for `(delta > I2C_TIMEOUT_TICK)`, which is not yet false. Since the hardware reports no errors either, I2C_OK was returned. By using `>=` in the if rather than `>`, this is fixed and I2C_TIMEOUT is now returned instead.
fpistm
approved these changes
Jan 17, 2020
|
@fpistm Thanks :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to: #748 (review)
When this timeout is triggered, I2C_OK was returned. This happens because in the
loop above, it checks for
(delta < I2C_TIMEOUT_TICK), so it breaks out of theloop as soon as
delta == I2C_TIMEOUT_TICK. Then, the if below checks for(delta > I2C_TIMEOUT_TICK), which is not yet false. Since the hardware reportsno errors either, I2C_OK was returned.
By using
>=in the if rather than>, this is fixed and I2C_TIMEOUT is nowreturned instead.