Skip to content

Rename this.seperator to this.separator #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename this.seperator to this.separator #28

wants to merge 1 commit into from

Conversation

BendingBender
Copy link

I suppose this constitutes a major bump...

@coveralls
Copy link

coveralls commented Aug 16, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 947cd61 on BendingBender:rename-seperator into 9457db6 on stream-utils:master.

@jonathanong
Copy link
Contributor

damn...

@jonathanong jonathanong self-assigned this Aug 16, 2017
@BendingBender
Copy link
Author

BendingBender commented Aug 16, 2017 •
edited
Loading

Alternatively, we could leave the misspelled attribute and deprecate it until the next major version while adding the correctly spelled one.

@draconteus
Copy link

Can we expect this PR to be merged? :)

@tinovyatkin tinovyatkin mentioned this pull request Oct 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanong jonathanong jonathanong approved these changes

Assignees

@jonathanong jonathanong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BendingBender @coveralls @jonathanong @draconteus