eslint: add rule preventing reaching to dist
#773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
broker
harbu
force-pushed
the
eslint-rule-prevent-dist
branch
from
4f8f4d8 to
bfdeabc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new eslint rule preventing reaching to
distdirectories.Future improvements
distdirectory) of a package except of course its main exports file. This has been possible in the past with TSLint (deprecated since 2019) with ruleno-submodule-imports, however I did not find an equivalent rule for eslint. There is a rule calledimport/no-internal-modulesbut it behaves in a bit more broader way as it will forbid certain deep imports within a package itself as well. See here for discussion on topic.