Support custom connector #199
Conversation
jannyHou
force-pushed
the
fix/custom-connector
branch
from
9f18b31 to
aab38c7
Compare
|
@bajtos Please review, thanks:) |
|
@slnode test please |
| var modelGen = givenDataSourceGenerator(); | ||
| helpers.mockPrompt(modelGen, { | ||
| name: 'test-custom', | ||
| customConnector: 'loopback-component-storage', |
There was a problem hiding this comment.
Please use a name that will never become a connector, e.g. async or lodash. I think the storage component is sort of connector-like.
There was a problem hiding this comment.
Right. "a name that will never become a connector" makes sense.
There was a problem hiding this comment.
async is already there, i use lodash then
|
@jannyHou reviewed, PTAL |
|
LGTM 👏 Please rebase on top of the current master and squash the commits. |
jannyHou
force-pushed
the
fix/custom-connector
branch
from
6f74795 to
0d3ec2f
Compare
| if (!pkg) return; | ||
| } | ||
|
|
||
| var npmModule = pkg.name || connector || this.connector; |
There was a problem hiding this comment.
@bajtos When I check the code again, I think it should be
var npmModule = pkg.name || this.connector instead of
var npmModule = pkg.name || connector || this.connector
The connector is either undefined or an object, not a string. Thought?
There was a problem hiding this comment.
The connector is either undefined or an object, not a string. Thought?
Ah, that's actually expected, see L200:
var connector = this.availableConnectors[this.connector];I think it should be
var npmModule = pkg.name || this.connector;
Makes sense to me! 👍
jannyHou
force-pushed
the
fix/custom-connector
branch
from
0d3ec2f to
28ad27a
Compare
|
@slnode test please |
Connect to strongloop/loopback#2265
Now when we choose a custom connector that not included in available connectors, it returns error.
This pr is created for supporting custom connector, and print a message to remind user manually add config then.